Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][ADD] website_sale_order_type #253

Merged
merged 5 commits into from
Jan 14, 2019
Merged

[10.0][ADD] website_sale_order_type #253

merged 5 commits into from
Jan 14, 2019

Conversation

SimoRubi
Copy link
Member

Bridge module for sale_order_type and website_sale

@SimoRubi SimoRubi changed the title [ADD] website_sale_order_type [10.0][ADD] website_sale_order_type Oct 16, 2018
@SimoRubi
Copy link
Member Author

Depends on OCA/sale-workflow#716

@SimoRubi SimoRubi force-pushed the 10.0-add-website_sale_order_type branch from 5acf8c5 to e6a2528 Compare January 4, 2019 08:35
@SimoRubi
Copy link
Member Author

SimoRubi commented Jan 7, 2019

Rebased on 10.0, @pedrobaeza could you update your review? Thanks

@SimoRubi
Copy link
Member Author

SimoRubi commented Jan 8, 2019

@OCA/e-commerce-maintainers could you please check? Thanks

@rafaelbn rafaelbn added this to the 10.0 milestone Jan 8, 2019
@rafaelbn
Copy link
Member

rafaelbn commented Jan 8, 2019

Hello @SimoRubi ,

I'm going to test it now.

About codecov/patch — 83.33% of diff hit (target 91.56%) I know it is not mandatory but is you think is affordable it could be great! 😄

Regards

rafaelbn
rafaelbn reviewed Jan 8, 2019
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SimoRubi,

Could you please add a USAGE secction?

I'm not sure how to teste this module.

I guess it is not usable for public users and only for registered users?

Thanks!

rafaelbn
rafaelbn approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot

website_sale_order_type/README.rst Show resolved Hide resolved
website_sale_order_type/README.rst Show resolved Hide resolved
@SimoRubi
Copy link
Member Author

SimoRubi commented Jan 11, 2019 •
edited
Loading

Big thanks @rafaelbn for your functional review, please check if the changes are good.

I also added the automated tests, I already had something stashed but it wasn't working due to some pesky env issues, after your pep talk I decided to go for it and finally found the solution here.

Now coverage is ✔️

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit fdb2d11 into OCA:10.0 Jan 14, 2019
joao-p-marques pushed a commit to Tecnativa/e-commerce that referenced this pull request Oct 26, 2020
@SimoRubi @joao-p-marques
[ADD] website_sale_order_type (OCA#253)
f2ec100
joao-p-marques pushed a commit to Tecnativa/e-commerce that referenced this pull request Oct 26, 2020
@SimoRubi @joao-p-marques
[ADD] website_sale_order_type (OCA#253)
8101da2
joao-p-marques pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 5, 2021
@SimoRubi @joao-p-marques
[ADD] website_sale_order_type (OCA#253)
069efe7
oihane pushed a commit to avanzosc/e-commerce that referenced this pull request Sep 16, 2021
@SimoRubi @oihane
[ADD] website_sale_order_type (OCA#253)
f5ad58b
oihane pushed a commit to avanzosc/e-commerce that referenced this pull request Sep 21, 2021
@SimoRubi @oihane
[ADD] website_sale_order_type (OCA#253)
957f98a
stefan-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Dec 15, 2022
@SimoRubi @stefan-tecnativa
[ADD] website_sale_order_type (OCA#253)
482d58f
stefan-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Dec 15, 2022
@SimoRubi @stefan-tecnativa
[ADD] website_sale_order_type (OCA#253)
22c5d69
pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 24, 2023
@SimoRubi @stefan-tecnativa
[ADD] website_sale_order_type (OCA#253)
91ac72d
pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Aug 10, 2023
@SimoRubi @pilarvargas-tecnativa
[ADD] website_sale_order_type (OCA#253)
45349b3
dalonsod pushed a commit to solvosci/e-commerce that referenced this pull request May 8, 2024
@SimoRubi @dalonsod
[ADD] website_sale_order_type (OCA#253)
e1bdaa7
david-s73 pushed a commit to Studio73/e-commerce that referenced this pull request Sep 17, 2024
@SimoRubi @david-s73
[ADD] website_sale_order_type (OCA#253)
d97b244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SimoRubi @rafaelbn @OCA-git-bot @pedrobaeza