[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #466

simahawk · 2022-02-24T15:08:54Z

Replaces #439.
In addition to it:

include fix from [13.0][FIX] delivery_auto_refresh: Fix error when adding products to cart on website #440
speed up tests w/ setUpClass + no tracking
unify lookup of params and use the right converter for boolean strings

Auto-refresh delivery price in sales orders =========================================== This module automates the delivery price handling for the following cases: * If you change any line in your draft sales order (SO), when saving, the delivery price will be adjusted without having to click on "→ Set price". * If specified in the system parameter, the delivery line can be also auto-added when creating/saving. * If you deliver a different quantity than the ordered one, the delivery price is adjusted on the linked SO when the picking is transferred. Configuration ============= * Activate developer mode. * Go to *Settings > Technical > Parameters > System Parameters*. * Locate the setting with key "delivery_auto_refresh.auto_add_delivery_line" or create a new one if not exists. * Put a non Falsy value (1, True...) if you want to add automatically the delivery line on save. Known issues / Roadmap ====================== * After confirming the sales order, the price of the delivery line (if exists) will be only updated after the picking is transferred, but not when you might modify the order lines. * There can be some duplicate delivery unset/set for assuring that the refresh is done on all cases. * On multiple deliveries, second and successive pickings update the delivery price, but you can't invoice the new delivery price. * This is only working from user interface, as there's no way of making compatible the auto-refresh intercepting create/write methods from sale order lines.

…ansferring

Currently translated at 100.0% (2 of 2 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_auto_refresh/zh_CN/

Currently translated at 100.0% (2 of 2 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_auto_refresh/pt_BR/

…+ add on create As the used method now has a check for not being used when the order is confirmed, so it collapses when you want to add the delivery line in that moment. Previous code didn't take into account the direct creation of the sales order.

For not having bad interaction with the rest of the tests.

Fixes OCA#260

new() doesn't invoke defaults, so you can get an SO without company for example, and interacts bad with other modules.

Currently translated at 100.0% (2 of 2 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_auto_refresh/sl/

In the core the onchange is now aligned with `partner_shipping_id` instead of `partner_id`. odoo/odoo@b6f91e3

…avoid error unmanaged

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_auto_refresh/

… after refresh to prevent warning decoration

When the company has different currency than the pricelist asociated to the partner. The final price is converted to the currency of the pricelist. With this changes we achieve to avoid this recomputation and solve this problems on tests. TT26914

…n website The steps to reproduce the problem are these: - Set delivery_auto_refresh.auto_add_delivery_line. - Set a default delivery method on the user's partner. - Place a new ecommerce order with that user adding to the cart. Doing this steps we get the error: Record does not exist or has been deleted. (Record: sale.order.line(63,), User: 1)

We should get as the same default carrier as Odoo does. TT34020

Added new config paramerter that automates de voiding of the delivery line for the case of returning a picking that just didn't go away from the warehouse (due to several causes like the customer cancelling the sale order in the last minute). This will only be performed if the order wasn't already invoiced and the return was set to refund. TT30359

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_auto_refresh/

simahawk · 2022-02-24T15:09:40Z

/ocabot migration delivery_auto_refresh

simahawk · 2022-02-24T15:21:45Z

tests failure seems unrelated. I'll get back to them when possible.

FAIL: TestRoutePutaway.test_wizard_send_shipping
Traceback (most recent call last):
  File "/home/travis/build/OCA/delivery-carrier/setup/delivery_carrier_pricelist/odoo/addons/delivery_carrier_pricelist/tests/test_delivery_pricelist.py", line 103, in test_wizard_send_shipping
    self.assertEqual(result, [{"exact_price": 0.0, "tracking_number": False}])
AssertionError: Lists differ: [{'exact_price': 10.0, 'tracking_number': False}] != [{'exact_price': 0.0, 'tracking_number': False}]
First differing element 0:
{'exact_price': 10.0, 'tracking_number': False}
{'exact_price': 0.0, 'tracking_number': False}
- [{'exact_price': 10.0, 'tracking_number': False}]
?                  -
+ [{'exact_price': 0.0, 'tracking_number': False}]
 
Module delivery_carrier_pricelist: 1 failures, 0 errors of 4 tests
FAIL: TestDeliveryMultiDestination.test_delivery_multi_destination
Traceback (most recent call last):
  File "/home/travis/build/OCA/delivery-carrier/setup/delivery_multi_destination/odoo/addons/delivery_multi_destination/tests/test_delivery_multi_destination.py", line 161, in test_delivery_multi_destination
    self.assertAlmostEqual(sale_order_line.price_unit, 50, 2)
AssertionError: 10.0 != 50 within 2 places
 
FAIL: TestDeliveryMultiDestination.test_picking_validation
Traceback (most recent call last):
  File "/home/travis/build/OCA/delivery-carrier/setup/delivery_multi_destination/odoo/addons/delivery_multi_destination/tests/test_delivery_multi_destination.py", line 203, in test_picking_validation
    self.assertEqual(picking.carrier_id, self.carrier_multi)
AssertionError: delivery.carrier(3,) != delivery.carrier(12,)

chienandalu · 2022-03-25T16:25:56Z

Can you add: #469

elvise · 2022-03-31T15:35:50Z

hi @simahawk any chance for this PR ?

francesco-ooops · 2022-04-04T11:07:11Z

@simahawk porting was finished in PR #472 , could you review?

thanks!

pedrobaeza and others added 30 commits February 24, 2022 11:58

OCA Transbot updated translations from Transifex

b4f087b

[IMP] delivery_auto_refresh: Make configurable also updating after tr…

ac18302

…ansferring

[MIG] : Migration to 12.0

68164a6

[FIX] delivery_auto_refresh: Don't modify standard behavior by default

f313887

For not having bad interaction with the rest of the tests.

[IMP] delivery_auto_refresh: keep discounts in delivery line

95ce840

[FIX] delivery_auto_refresh: force parameter not existing in v12

23ff3bc

Fixes OCA#260

[FIX] delivery_auto_refresh: Create SO with default values

1337b9b

new() doesn't invoke defaults, so you can get an SO without company for example, and interacts bad with other modules.

Fix auto_refresh unit tests

9f23bfc

In the core the onchange is now aligned with `partner_shipping_id` instead of `partner_id`. odoo/odoo@b6f91e3

[12.0][FIX] update delivery with multiple lines fails - add check to …

f9ad3bf

…avoid error unmanaged

[IMP] delivery_auto_refresh: black, isort

f08006c

[MIG] delivery_auto_refresh: Migration to v13.0

ef4fcae

[UPD] Update delivery_auto_refresh.pot

88ecbe5

[UPD] README.rst

04315c9

[13.0][IMP]delivery_auto_refresh: mark recompute_delivery_price false…

90c0f67

… after refresh to prevent warning decoration

delivery_auto_refresh 13.0.1.0.1

12e8a61

delivery_auto_refresh 13.0.1.0.2

747d80d

delivery_auto_refresh 13.0.1.0.3

7f3f90e

[FIX] delivery_auto_refresh: behave as core

dc7eb3b

We should get as the same default carrier as Odoo does. TT34020

delivery_auto_refresh 13.0.1.0.4

1f61b8a

[UPD] Update delivery_auto_refresh.pot

b1c3b77

OCA-git-bot and others added 6 commits February 24, 2022 11:58

[UPD] README.rst

4842693

delivery_auto_refresh 13.0.1.0.5

9a7b9ab

[MIG] delivery_auto_refresh: Migration to 14.0

381714c

delivery_auto_refresh: centralize get_param

f00dd8d

delivery_auto_refresh: tests use setUpClass

682f124

simahawk mentioned this pull request Feb 24, 2022

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #439

Closed

2 tasks

OCA-git-bot added this to the 14.0 milestone Feb 24, 2022

OCA-git-bot mentioned this pull request Feb 24, 2022

Migration to version 14.0 #297

Closed

21 tasks

pedrobaeza mentioned this pull request Apr 1, 2022

[14.0] Migration: delivery_auto_refresh 13.0->14.0 #471

Closed

ilyasProgrammer mentioned this pull request Apr 4, 2022

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #472

Closed

ilyasProgrammer mentioned this pull request Apr 5, 2022

[14.0] delivery_auto_refresh: migration to v14 #473

Merged

simahawk closed this Apr 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #466

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #466

simahawk commented Feb 24, 2022

simahawk commented Feb 24, 2022

simahawk commented Feb 24, 2022

chienandalu commented Mar 25, 2022

elvise commented Mar 31, 2022

francesco-ooops commented Apr 4, 2022

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #466

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #466

Conversation

simahawk commented Feb 24, 2022

simahawk commented Feb 24, 2022

simahawk commented Feb 24, 2022

chienandalu commented Mar 25, 2022

elvise commented Mar 31, 2022

francesco-ooops commented Apr 4, 2022