Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #439

Closed
wants to merge 26 commits into from
Closed

[14.0][MIG] delivery_auto_refresh: Migration to 14.0 #439

wants to merge 26 commits into from

Conversation

yankinmax
Copy link
Contributor

@yankinmax yankinmax commented Nov 16, 2021 •
edited
Loading

Here what has changed:

  • action_done on 'stock.picking' become _action_done
  • to avoid Python standard Exception
    TypeError: 'module' object is not callable
    changed
    from odoo.tools import safe_eval
    to
    from odoo.tools.safe_eval import safe_eval

pedrobaeza and others added 25 commits November 16, 2021 19:15
@pedrobaeza @yankinmax
[ADD] delivery_auto_refresh: Auto-refresh delivery price in sales orders
b0fa9e0 
Auto-refresh delivery price in sales orders
===========================================

This module automates the delivery price handling for the following cases:

* If you change any line in your draft sales order (SO), when saving, the
  delivery price will be adjusted without having to click on "→ Set price".
* If specified in the system parameter, the delivery line can be also
  auto-added when creating/saving.
* If you deliver a different quantity than the ordered one, the delivery price
  is adjusted on the linked SO when the picking is transferred.

Configuration
=============

* Activate developer mode.
* Go to *Settings > Technical > Parameters > System Parameters*.
* Locate the setting with key "delivery_auto_refresh.auto_add_delivery_line"
  or create a new one if not exists.
* Put a non Falsy value (1, True...) if you want to add automatically the
  delivery line on save.

Known issues / Roadmap
======================

* After confirming the sales order, the price of the delivery line (if exists)
  will be only updated after the picking is transferred, but not when you
  might modify the order lines.
* There can be some duplicate delivery unset/set for assuring that the refresh
  is done on all cases.
* On multiple deliveries, second and successive pickings update the delivery
  price, but you can't invoice the new delivery price.
* This is only working from user interface, as there's no way of making
  compatible the auto-refresh intercepting create/write methods from sale order
  lines.
@oca-transbot @yankinmax
OCA Transbot updated translations from Transifex
021faa5
@pedrobaeza @yankinmax
[IMP] delivery_auto_refresh: Make configurable also updating after tr…
18fea2d 
…ansferring
@cubells @yankinmax
[MIG] : Migration to 12.0
c489828
@liweijie0812 @yankinmax
Translated using Weblate (Chinese (Simplified))
6fc7582 
Currently translated at 100.0% (2 of 2 strings)

Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_auto_refresh
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_auto_refresh/zh_CN/
@liweijie0812 @yankinmax
Translated using Weblate (Chinese (Simplified))
5bf650c 
Currently translated at 100.0% (2 of 2 strings)

Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_auto_refresh
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_auto_refresh/zh_CN/
@yankinmax
Translated using Weblate (Portuguese (Brazil))
a2091eb 
Currently translated at 100.0% (2 of 2 strings)

Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_auto_refresh
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_auto_refresh/pt_BR/
@pedrobaeza @yankinmax
[FIX] delivery_auto_refresh: Avoid error when confirming sales order …
4d78333 
…+ add on create

As the used method now has a check for not being used when the order is confirmed, so
it collapses when you want to add the delivery line in that moment.

Previous code didn't take into account the direct creation of the sales order.
@pedrobaeza @yankinmax
[FIX] delivery_auto_refresh: Don't modify standard behavior by default
6350062 
For not having bad interaction with the rest of the tests.
@chienandalu @yankinmax
[IMP] delivery_auto_refresh: keep discounts in delivery line
a13c9f8
@pedrobaeza @yankinmax
[FIX] delivery_auto_refresh: force parameter not existing in v12
bdd64e3 
Fixes OCA#260
@pedrobaeza @yankinmax
[FIX] delivery_auto_refresh: Create SO with default values
ed7a210 
new() doesn't invoke defaults, so you can get an SO without company for example,
and interacts bad with other modules.
@sysadminmatmoz @yankinmax
Translated using Weblate (Slovenian)
f618783 
Currently translated at 100.0% (2 of 2 strings)

Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_auto_refresh
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_auto_refresh/sl/
@yvaucher @yankinmax
Fix auto_refresh unit tests
5fa8855 
In the core the onchange is now aligned with `partner_shipping_id`
instead of `partner_id`.
odoo/odoo@b6f91e3
@sergiocorato @yankinmax
[12.0][FIX] update delivery with multiple lines fails - add check to …
ba472dc 
…avoid error unmanaged
@CarlosRoca13 @yankinmax
[IMP] delivery_auto_refresh: black, isort
8b18cb0
@CarlosRoca13 @yankinmax
[MIG] delivery_auto_refresh: Migration to v13.0
b6ae94e
@oca-travis @yankinmax
[UPD] Update delivery_auto_refresh.pot
ca6f41e
@OCA-git-bot @yankinmax
[UPD] README.rst
dccb62a
@oca-transbot @yankinmax
Update translation files
d279bca 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_auto_refresh
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_auto_refresh/
@JordiMForgeFlow @yankinmax
[13.0][IMP]delivery_auto_refresh: mark recompute_delivery_price false…
23c1dfc 
… after refresh to prevent warning decoration
@OCA-git-bot @yankinmax
delivery_auto_refresh 13.0.1.0.1
f671ad2
@CarlosRoca13 @yankinmax
[FIX] delivery_auto_refresh: Error on test
97c7910 
When the company has different currency than the pricelist asociated to the partner. The final price is converted to the currency of the pricelist.

With this changes we achieve to avoid this recomputation and solve this problems on tests.

TT26914
@OCA-git-bot @yankinmax
delivery_auto_refresh 13.0.1.0.2
f2a967e
@yankinmax
[IMP] : black, isort, prettier
c2d3bbf
@simahawk
Copy link
Contributor

please check the build

@yankinmax yankinmax force-pushed the 14.0-mig-delivery_auto_refresh branch from e74da92 to 3a78311 Compare November 17, 2021 11:24
@yankinmax
Copy link
Contributor Author

@simahawk I checked it and couldn't solve the error as it isn't related to delivery_auto_refresh. Unfortunately, I didn't investigate it extensively till you wrote to do it and already merged parent PR. From what I see now, after the last update, the warning message in delivery_auto_refresh has gone.

@CarlosRoca13
Copy link
Contributor

CarlosRoca13 commented Nov 25, 2021 •
edited
Loading

Please add this fix on the migration:

@simahawk simahawk mentioned this pull request Feb 24, 2022
Closed
@simahawk
Copy link
Contributor

moving to #466

@simahawk simahawk closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaniszewska-dev ajaniszewska-dev ajaniszewska-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.