[IMP] sale_financial_risk: Send email when risk confirmed #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
SirAionTech
force-pushed
the
16.0-imp-sale_financial_risk-risk_template
branch
from
0278282
to
5f8164c
Compare
|
Rebased on |
carlosdauden
suggested changes
Dec 2, 2024
Comment on lines
1
to
25
| # Copyright 2024 Simone Rubino - Aion Tech | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import models | ||
|
|
||
|
|
||
| class PartnerRiskExceededWiz(models.TransientModel): | ||
| _inherit = "partner.risk.exceeded.wiz" | ||
|
|
||
| def _post_sale_order_confirm_risk(self, origin_record): | ||
| template = origin_record.company_id.sale_order_confirm_risk_template_id | ||
| if template: | ||
| template.send_mail(origin_record.id) | ||
|
|
||
| def button_continue(self): | ||
| continue_result = super().button_continue() | ||
| origin_record = self.origin_reference | ||
| if origin_record._name == "sale.order": | ||
| self._post_sale_order_confirm_risk(origin_record) | ||
| return continue_result |
There was a problem hiding this comment.
Unnecessary with the changes proposed here #393 (review)
There was a problem hiding this comment.
Thanks for having a look!
As I wrote in #393 (comment), I think it's better to have the behavior for sale orders explicitly managed, so I have improved the documentation of this method to explain that.
SirAionTech
force-pushed
the
16.0-imp-sale_financial_risk-risk_template
branch
from
5f8164c
to
6831e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to send a configurable email template when risk for an invoice is explicitly exceeded in the wizard.
Similar to #393, but for sale orders.