[IMP] account_financial_risk: Send email when risk confirmed #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @carlosdauden, |
SirAionTech
force-pushed
the
16.0-imp-account_financial_risk-risk_template
branch
from
2a7c330 to
f94b108
Compare
SirAionTech
force-pushed
the
16.0-imp-account_financial_risk-risk_template
branch
from
f94b108 to
cf45b8d
Compare
SirAionTech
force-pushed
the
16.0-imp-account_financial_risk-risk_template
branch
from
cf45b8d to
2376dad
Compare
carlosdauden
suggested changes
Dec 2, 2024
There was a problem hiding this comment.
Try this to simplify the extension with other modules as #394
| template = origin_record.company_id.account_move_confirm_risk_template_id | ||
| if template: | ||
| template.send_mail(origin_record.id) | ||
|
|
||
| def button_continue(self): | ||
| self.ensure_one() |
There was a problem hiding this comment.
Suggested change
| self.ensure_one() | |
| self.ensure_one() | |
| res = getattr( | |
| self.origin_reference.with_context(bypass_risk=True), self.continue_method | |
| )() | |
| self._post_confirm_risk() | |
| return res |
Comment on lines
35
to
36
| def _post_account_move_confirm_risk(self, origin_record): | ||
| template = origin_record.company_id.account_move_confirm_risk_template_id |
There was a problem hiding this comment.
Suggested change
| def _post_account_move_confirm_risk(self, origin_record): | |
| template = origin_record.company_id.account_move_confirm_risk_template_id | |
| def _post_confirm_risk(self): | |
| origin_record = self.origin_reference | |
| model_preffix = origin_record._name.replace('.', '_') | |
| template = getattr(origin_record.company_id, f"{model_preffix}_confirm_risk_template_id", False) |
There was a problem hiding this comment.
Hi, thanks for your suggestions!
Sure this would simplify code for other modules, but I think it would become too hard to understand what's happening as it sometimes happens when reflection is used.
I created this hook to explicitly do things for account.move records, (that's why its name is _post_*account_move*_confirm_risk); I've added documentation and modified its signature to make it more clear, let me know if that's ok for you.
Comment on lines
+42
to
+53
| origin_record = self.origin_reference | ||
| continue_result = getattr( | ||
| origin_record.with_context(bypass_risk=True), self.continue_method | ||
| )() | ||
| if origin_record._name == "account.move": | ||
| self._post_account_move_confirm_risk(origin_record) | ||
| return continue_result |
There was a problem hiding this comment.
Suggested change
| origin_record = self.origin_reference | |
| continue_result = getattr( | |
| origin_record.with_context(bypass_risk=True), self.continue_method | |
| )() | |
| if origin_record._name == "account.move": | |
| self._post_account_move_confirm_risk(origin_record) | |
| return continue_result |
SirAionTech
force-pushed
the
16.0-imp-account_financial_risk-risk_template
branch
from
2376dad to
449b2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to send a configurable email template when risk for an invoice is explicitly exceeded in the wizard.
Also track the credit limit date because it is just as important as the amount (that is already tracked).