Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] automation_oca add dependencies to use today() and datetime in domain (filter) #8

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

gaelTorrecillas
Copy link
Contributor

hello,

this pr purpose to fix on the use datetime in filter (domain) #5

@flotho
Copy link
Member

flotho commented Sep 6, 2024

Hi @gaelTorrecillas thanks for this PR, any chance to fix the lint ?

@pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 6, 2024
@gaelTorrecillas gaelTorrecillas changed the title [16.0] add dependancies to use today() and datetime in domain (filter) [16.0] automation_oca add dependencies to use today() and datetime in domain (filter) Sep 9, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is still incorrect (for both the length of the first line and the tag):

[IMP] automation_oca: Allow some expressions in domain

This commit adds the corresponding imports and preparation
code for using some variables and expressions like `today()`,
`datetime`, `user`, etc in the domain (filter) of the automation
configuration.

I also miss some explanation of this in the help of the field.

automation_oca/models/automation_configuration.py Outdated Show resolved Hide resolved
This commit adds the corresponding imports and preparation
code for using some variables and expressions like `today()`,
`datetime`, `user`, etc in the domain (filter) of the automation
configuration.
@pedrobaeza
Copy link
Member

The help on the field is still missing, but I don't block more.

@pedrobaeza pedrobaeza requested a review from etobella September 10, 2024 09:10
@flotho
Copy link
Member

flotho commented Sep 10, 2024

The help on the field is still missing, but I don't block more.

Thanks @pedrobaeza , @gaelTorrecillas could be proud of this validation.

@gaelTorrecillas
Copy link
Contributor Author

Hello pedro,

thanks you for your reviews.

Regards

@flotho
Copy link
Member

flotho commented Sep 11, 2024

Ping @DorianMAG @JulienMartinez , thanks for your review.
@gaelTorrecillas could you produce a usecase example on runboat with a screenshot.

@pedrobaeza
Copy link
Member

Another option is to include demo data with such domain.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes to complete the module.

automation_oca/models/automation_configuration.py Outdated Show resolved Hide resolved
@gaelTorrecillas gaelTorrecillas force-pushed the 16.0_domain branch 3 times, most recently from 831c803 to 6674669 Compare September 12, 2024 10:05
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on runboat, LGTM

@gaelTorrecillas
Copy link
Contributor Author

Hello,

I added demo and user and ref in the fields info.

Regards,

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-8-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8a15246 into OCA:16.0 Sep 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 47382ba. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants