-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] automation_oca add dependencies to use today() and datetime in domain (filter) #8
Conversation
Hi @gaelTorrecillas thanks for this PR, any chance to fix the lint ? |
Please follow commit message guidelines: |
f06b859
to
1145d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message is still incorrect (for both the length of the first line and the tag):
[IMP] automation_oca: Allow some expressions in domain
This commit adds the corresponding imports and preparation
code for using some variables and expressions like `today()`,
`datetime`, `user`, etc in the domain (filter) of the automation
configuration.
I also miss some explanation of this in the help of the field.
This commit adds the corresponding imports and preparation code for using some variables and expressions like `today()`, `datetime`, `user`, etc in the domain (filter) of the automation configuration.
1145d72
to
2100849
Compare
The help on the field is still missing, but I don't block more. |
Thanks @pedrobaeza , @gaelTorrecillas could be proud of this validation. |
Hello pedro, thanks you for your reviews. Regards |
Ping @DorianMAG @JulienMartinez , thanks for your review. |
Another option is to include demo data with such domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes to complete the module.
831c803
to
6674669
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on runboat, LGTM
Hello, I added demo and user and ref in the fields info. Regards, |
This PR has the |
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 47382ba. Thanks a lot for contributing to OCA. ❤️ |
hello,
this pr purpose to fix on the use datetime in filter (domain) #5