[16.0][FIX] automation_oca: pass eval_context in domain #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotho
suggested changes
Oct 7, 2024
gaelTorrecillas
force-pushed
the
16.0_domain_step
branch
from
2957fcf to
4893240
Compare
gaelTorrecillas
changed the title
[FIX] automation_oca: pass eval_context in step domain safe_eval
|
On my way to merge this fine PR! |
pedrobaeza
changed the title
|
Congratulations, your PR was merged at 06689b8. Thanks a lot for contributing to OCA. ❤️ |
|
thanks @pedrobaeza , we really appreciate your approbation. |
|
thanks you for yours review and approbation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Following my first pr #8 , when we use a domain with today, datetime etc, we have an error when we add step.
So I add context in safe_eval contained in the step file.