Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_move_name_sequence migration to 18.0 #1954

Open
wants to merge 61 commits into
base: 18.0
Choose a base branch
from

Conversation

BertVGroenendael
Copy link

No description provided.

alexis-via and others added 30 commits October 16, 2024 14:23
This module restores the good old behavior where journal entry numbers
were generated from a sequence configured on the journal.
Add post-install script to create a sequence for all existing journals
Update README accordingly
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
After remove required=True for journal.sequence_id field it is possible to post an invoice with misconfigured journal with empty sequence

So, this constraint will raise an error for this kind of cases since that using '/' could raise the unique constraint for all other moves
The required flag was wrong for sequence_id and refund_sequence_id

So, it was not possible to store any change in journal for journal different to sale and purchase
…efix

In case you want name your invoice YYYY-MM-SEQ (ie: 2022-07-00001)
where:
 * YYYY: is the account move year
 * MM: is the account move month
 * SEQ: is a numerical sequence that is continue along the fiscal year
   assuming fiscal year is over two years (ie: from july to june next year)

Before this commit the sequence prefix use now() to be compute but the
range is selected with the account move date.

This commit make consistency computing prefix with the account
move date as well.

So account move manage the first janunary for the last day of
the previous year will properly use the account move date.

Co-authored-by: Alexis de Lattre <[email protected]>
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
…e" module the "_get_last_sequence" method does not have to propagate the with_prefix parameter. The sequence_prefix parameter will not be completed and will give error as it is False in this line of code. https://github.com/OCA/OCB/blob/16.0/addons/account/models/sequence_mixin.py#L169
Currently translated at 100.0% (20 of 20 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_name_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_name_sequence/fr/
Rename hooks file and use post_init_hook method to create journal sequences
after module installation.
…the name

The core compute function for the name is calling at the end the function self._inverse_name(),
which updates the payment_reference when required.
This code was currently missing, causing the payment_reference not being properly computed,
for example, when using QR-Bills.
mymage and others added 25 commits October 16, 2024 14:23
Currently translated at 100.0% (20 of 20 strings)

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/it/
In v16, _onchange_journal_id is defined to update name when journal_id is modified
During the creation of new account.move, this onchange is triggered and called the standard _compute_name method

How to reproduce issue:
* Create new invoice
=> Name is defined instead of to be 'Draft'
…sequence

A demo ir_sequence record with 'standard' implementation was
assigned to the payment journal so that no concurrency errors arise
from using 'no gap' sequences when attempting to create multiple payments.
In case an alias is configured to fecth email to generate
account entries. the new_message method directly call the
_compute_name on account move which call the legacy code
provide by account odoo module which should be avoid here.

To reproduce:

* configure an alias on your purchase journal
* send an email to that alias
* the invoice is draft with a number

to mitigate this behavior the suggested patch overwritte
the former method '_compute_name' and call the new implemented
method '_compute_name_by_sequence'.
…invoices

Add demo data with standard implementation sequences

In order to test locks issues without changing data (then reverting)
Split the context definition in sequence_id and refund_sequence_id
fields into multiple lines to improve readability.
Update name of view files to follow guidelines.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/
Currently translated at 100.0% (22 of 22 strings)

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/it/
Currently translated at 100.0% (22 of 22 strings)

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/es/
@BertVGroenendael BertVGroenendael mentioned this pull request Oct 17, 2024
22 tasks
@BertVGroenendael BertVGroenendael force-pushed the 18.0-mig-account_move_name_sequence branch 2 times, most recently from cbae712 to 830bc2e Compare October 17, 2024 07:29
@BertVGroenendael BertVGroenendael force-pushed the 18.0-mig-account_move_name_sequence branch from 830bc2e to 598e640 Compare October 21, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.