Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ir_sequence: Fix creating date_range_seq with range_month and range_day #91019

Closed
wants to merge 2 commits into from

Conversation

moylop260
Copy link
Contributor

Using range_day the range of the dates for new date_range_sequence
record should be only one day

Using range_month the range of the dates for new date_range_sequence
record should be only one month

Before of this fix the date created was a range of many days or months

It fixes the range of new sequences

Add new unittests

@robodoo
Copy link
Contributor

robodoo commented May 10, 2022

Pull request status dashboard

@moylop260
Copy link
Contributor Author

Hi @mart-e

Who could help us to review it?

Thanks in advance!

moylop260 added a commit to vauxoo-dev/account-financial-tools that referenced this pull request May 10, 2022
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
…ange_day

Using range_day the range of the dates for new date_range_sequence
record should be only one day

Using range_month the range of the dates for new date_range_sequence
record should be only one month

Before of this fix the date created was a range of many days or months

It fixes the range of new sequences

Add new unittests
moylop260 added a commit to vauxoo-dev/account-financial-tools that referenced this pull request May 10, 2022
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
moylop260 added a commit to vauxoo-dev/account-financial-tools that referenced this pull request May 10, 2022
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
@mart-e mart-e requested a review from qdp-odoo May 12, 2022 14:53
frahikLV pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request May 25, 2022
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
@frahikLV
Copy link
Contributor

Hey @moylop260 !

Include the refactor on this PR too

frahikLV pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request May 26, 2022
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
dreispt pushed a commit to ursais/account-financial-tools that referenced this pull request Jul 26, 2022
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
RodrigoBM pushed a commit to factorlibre/account-financial-tools that referenced this pull request Nov 24, 2022
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
@legalsylvain
Copy link
Contributor

hi @mart-e, what is the state of this PR ?

@mart-e mart-e requested review from a team, xmo-odoo and rco-odoo and removed request for a team April 17, 2023 07:49
ddejong-therp pushed a commit to ddejong-therp/account-financial-tools that referenced this pull request Aug 31, 2023
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
andreagidaltig pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Sep 30, 2023
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
andreagidaltig pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Oct 9, 2023
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
andreagidaltig pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Oct 9, 2023
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
moitabenfdz pushed a commit to DynAppsNV/account-financial-tools that referenced this pull request Nov 13, 2023
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
@qdp-odoo
Copy link
Contributor

@william-andre I suppose this ain't a problem anymore. Maybe it's just worth checking the tests to see if it is indeed fixed, and see if this is tested or not.

@william-andre
Copy link
Contributor

@qdp-odoo This PR is about ir.sequence, if you are not confusing it with sequence.mixin, so I'm pretty sure nothing has changed regarding this.
Note that the mixin doesn't allow for a range based on days.

I can take a closer look later, but I believe it would be a good idea to go further with this PR. (probably in 15.0 as 14.0 has been deprecated)

@william-andre william-andre removed their assignment Nov 20, 2023
@qdp-odoo
Copy link
Contributor

@qdp-odoo This PR is about ir.sequence, if you are not confusing it with sequence.mixin, so I'm pretty sure nothing has changed regarding this. Note that the mixin doesn't allow for a range based on days.

I can take a closer look later, but I believe it would be a good idea to go further with this PR. (probably in 15.0 as 14.0 has been deprecated)

I, indeed, asked you without even reading the diff and got confused 🙈 Sorry 'bout that.

I don't understand the commit message, let's assume this either isn't important or is fixed, @moylop260 feel free to reopen and better explain if you think it's still needed.

thanks for the contribution, anyway

@qdp-odoo qdp-odoo closed this Nov 27, 2023
keylor2906 pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Dec 5, 2023
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
keylor2906 pushed a commit to Vauxoo/account-financial-tools that referenced this pull request Dec 5, 2023
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
cormaza pushed a commit to cormaza/account-financial-reporting that referenced this pull request Jun 2, 2024
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
BertVGroenendael pushed a commit to DynAppsNV/account-financial-tools that referenced this pull request Oct 16, 2024
…ange_day

More info about:
 - odoo/odoo#91019

TODO: Revert this commit after it is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants