Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10.0 account financial report qweb fix import #274

Closed
wants to merge 2 commits into from
Closed

10.0 account financial report qweb fix import #274

wants to merge 2 commits into from

Conversation

yelizariev
Copy link
Member

Applies #229 to 10.0

yajo and others added 2 commits February 18, 2017 16:30
@yajo
[FIX][account_financial_report_qweb] Fix ImportError.
ceb6dad 
It was happening when `xlsxwriter` python module was not available.

Bump version, add external dependencies.
@yajo
Avoid coverage errors on an ImportError that will never happen in bots.
6972258
sbidoul
sbidoul requested changes Feb 18, 2017
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yelizariev could you forward port #242 instead?

@yelizariev yelizariev mentioned this pull request Feb 20, 2017
Merged
@yelizariev
Copy link
Member Author

yelizariev commented Feb 20, 2017 •
edited
Loading

@sbidoul ok, but I have no idea what the module does. Check my comment in #276

@sbidoul
Copy link
Member

sbidoul commented Feb 22, 2017

superseded by #276

@sbidoul sbidoul closed this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yelizariev @sbidoul @pedrobaeza @yajo