[FIX][account_financial_report_qweb] Fix ImportError. #229
Conversation
| @@ -50,6 +50,7 @@ Contributors | |||
| * Francesco Apruzzese <[email protected]> | |||
| * Lorenzo Battistini <[email protected]> | |||
| * Julien Coux <[email protected]> | |||
| * Jairo Llopis <[email protected]> | |||
There was a problem hiding this comment.
This contribution is very little to include you here. In fact, it's a patch.
There was a problem hiding this comment.
git blame will know that, but here we put only relevant contributors, or the list would be big for all the modules.
There was a problem hiding this comment.
This seems important to me. 😛
|
Bump version number |
|
Please, wrap the import xslxwriter at a lower level. Note that I've never had an import error since I'm using pip to properly install the addons I need. |
yajo
force-pushed
the
9.0-account_financial_report_qweb-fix_importerror
branch
from
057f978 to
d5e8aa2
Compare
| "python": [ | ||
| "xlsxwriter", | ||
| ], | ||
| }, |
There was a problem hiding this comment.
AFAICS xslxwriter is not a direct dependency of afr_qweb. It is a dependency of report_xslx, so it should not be declared here.
There was a problem hiding this comment.
I updated the patch and put the try lower in the stack. Please review that, you probably missed that.
There was a problem hiding this comment.
And it should be split in 2 modules: one for the QWeb part, and the other for XLSX support extension.
There was a problem hiding this comment.
That's the job for another PR. 😄
yajo
force-pushed
the
9.0-account_financial_report_qweb-fix_importerror
branch
from
d5e8aa2 to
289bc21
Compare
It was happening when `xlsxwriter` python module was not available. Bump version, add external dependencies.
yajo
force-pushed
the
9.0-account_financial_report_qweb-fix_importerror
branch
from
289bc21 to
7eb797a
Compare
|
This one should be fast tracked IMHO. |
|
Ping! 😊 |
|
💤 |
|
@sbidoul any feedback on this? |
|
@pedrobaeza @yajo I created #241. I'd prefer to get that fixed instead of this PR. What do you think? |
|
OK, but if the solution is not still done, I would vote for merging this meanwhile |
It was happening when
xlsxwriterpython module was not available.@Tecnativa