-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][OU] account_financial_report: migration script #1188
Open
chienandalu
wants to merge
1
commit into
OCA:16.0
Choose a base branch
from
Tecnativa:16.0-ou-account_financial_report
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
account_financial_report/migrations/16.0.1.0.0/pre-migration.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Copyright 2024 Tecnativa - David Vidal | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
from openupgradelib import openupgrade | ||
|
||
|
||
@openupgrade.migrate() | ||
def migrate(env, version): | ||
"""Pre-create analytic_account_ids m2m relation and pre-fill it""" | ||
env.cr.execute( | ||
""" | ||
CREATE TABLE account_analytic_account_account_move_line_rel ( | ||
account_move_line_id INTEGER NOT NULL, | ||
account_analytic_account_id INTEGER NOT NULL, | ||
PRIMARY KEY(account_move_line_id, account_analytic_account_id) | ||
); | ||
COMMENT ON TABLE account_analytic_account_account_move_line_rel IS | ||
'RELATION BETWEEN account_move_line AND account_analytic_account'; | ||
CREATE INDEX ON account_analytic_account_account_move_line_rel ( | ||
account_analytic_account_id,account_move_line_id | ||
); | ||
""" | ||
) | ||
openupgrade.logged_query( | ||
env.cr, | ||
""" | ||
INSERT INTO account_analytic_account_account_move_line_rel ( | ||
account_move_line_id, account_analytic_account_id | ||
) | ||
SELECT | ||
aml.id AS account_move_line_id, | ||
jsonb_each.key::int AS account_analytic_account_id | ||
FROM | ||
account_move_line aml, | ||
jsonb_each(aml.analytic_distribution) AS jsonb_each | ||
WHERE | ||
aml.analytic_distribution IS NOT NULL; | ||
""", | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FK are missing here, isn't it? Why not do it the trick of creating a fake table on pre, and then remove it on post to then call the ORM that creates it correctly?
You can find an example in v16 here:
https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_scripts/scripts/hr_skills/16.0.1.0/post-migration.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @chienandalu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @chienandalu