Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU] account_financial_report: migration script #1188

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

chienandalu
Copy link
Member

Pre-fill the new analytic_account_ids computed M2M.

In a database with millions of account move lines we go from ~40 minutes to pre-compute the relation to 7 seconds 🙂

cc @Tecnativa TT46020

Pre-fill new analytic_account_ids computed M2M.

TT46020
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 13, 2024
'RELATION BETWEEN account_move_line AND account_analytic_account';
CREATE INDEX ON account_analytic_account_account_move_line_rel (
account_analytic_account_id,account_move_line_id
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FK are missing here, isn't it? Why not do it the trick of creating a fake table on pre, and then remove it on post to then call the ORM that creates it correctly?

You can find an example in v16 here:

https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_scripts/scripts/hr_skills/16.0.1.0/post-migration.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants