Breaking change between 2.2.6 and 2.2.8

[EvgenyOrekhov]

Now eslint-plugin-decorator-position with default settings suddenly wants property decorators to be on the line above: https://github.com/EvgenyOrekhov/eslint-config-hardcore/blob/cf5c68bf2e2a0e9e5d853266461cde3d3d160b71/sort-class-members-test.js#L33

See EvgenyOrekhov/eslint-config-hardcore#172.

[NullVoxPopuli]

Well that wasn't supposed to happen. :(

Can you try to submit a reproduction? Either as an eslint test or reproduction smoke test?

[EvgenyOrekhov]

I'm trying, but I can't reproduce it as an ESLint test or reproduction smoke test.

I'm trying to debug it, I can see that printWidth ends up being undefined, and then NaN:

{
  printWidth: undefined,
  overrides: { 'prefer-inline': [ 'decorator' ], above: [ 'decorator' ] }
}
{ inlineLength: 37, printWidth: NaN }

Perhaps it has something to do with that?

[NullVoxPopuli]

Oh! That could certainly be it! I refactored that stuff
How is your prettier config setup? (Eslint, separate config, etc)

[EvgenyOrekhov]

I was able to reproduce the issue by removing this line from the smoke test:

eslint-plugin-decorator-position/smoke-tests/integration/external-config-prettier/.prettierrc.js

Line 3 in 74f5b36

printWidth: 100,

[NullVoxPopuli]

Excellent find!

I can get a fix pr up today, if you don't want to

[EvgenyOrekhov]

How is your prettier config setup?

In my ESLint config I use "extends": ["plugin:prettier/recommended"], and I do not have .prettierrc.js. But in some of my apps I use .prettierrc.js. The issue is reproducible in both cases when printWidth is not defined.

I can get a fix pr up today, if you don't want to

I'm struggling to figure out your development flow, can't really figure out how to use the smoke tests and whatnot. So, I would appreciate it if you fixed it :)

[NullVoxPopuli]

awesome! and thanks for the feedback. I'll try to make the CONTRIBUTING.md useful

[NullVoxPopuli]

🎉 This issue has been resolved in version 2.2.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀