Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when declare syntax is used with decorators, the rule conflicts with prettier for long lines. #195

Closed
NullVoxPopuli opened this issue Nov 9, 2020 · 1 comment
Closed

when declare syntax is used with decorators, the rule conflicts with prettier for long lines. #195

NullVoxPopuli opened this issue Nov 9, 2020 · 1 comment
Labels
released

Comments

@NullVoxPopuli
Copy link
Owner

Example:

          // Would be 113 characters inline
          @service('addon-name/-private/do-not-use/the-name-of-the-service')
          declare someObfuscatedPrivateService: Service;

if set to be "inline", prettier will want to keep it as is, but the rule would inline the decorator
NullVoxPopuli added a commit that referenced this issue Nov 9, 2020
@NullVoxPopuli
fix(#195): decorators using declare now respect prettier -- I also de…
376c517 
…leted most of the length detection code
NullVoxPopuli added a commit that referenced this issue Nov 9, 2020
@NullVoxPopuli
fix(#195): decorators using declare now respect prettier
68a39d0 
Additionally,
- deleted most of the length detection code
- new smoke test
- some general cleanup
NullVoxPopuli added a commit that referenced this issue Nov 9, 2020
@NullVoxPopuli
fix(#195): decorators using declare now respect prettier
607f4ba 
Additionally,
- deleted most of the length detection code
- new smoke test
- some general cleanup
github-actions bot pushed a commit that referenced this issue Nov 9, 2020
@semantic-release-bot
chore(release): 2.2.8 [skip ci]
74f5b36 
## [2.2.8](v2.2.7...v2.2.8) (2020-11-09)

### Bug Fixes

* **#195:** decorators using declare now respect prettier ([607f4ba](607f4ba)), closes [#195](#195)
@NullVoxPopuli
Copy link
Owner Author

🎉 This issue has been resolved in version 2.2.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

NullVoxPopuli added a commit that referenced this issue Nov 9, 2020
@NullVoxPopuli
fix(#196): fix prettier unspecified printWidth
b8e5d53 
issue introduced in #195.
was causing inline decorators to move to the line above because
`Number(undefined)` is 0, and having a printWidth of 0 breaks
all sorts of formatting.
NullVoxPopuli added a commit that referenced this issue Nov 9, 2020
@NullVoxPopuli
fix(#196): fix prettier unspecified printWidth
2c327c8 
issue introduced in #195.
was causing inline decorators to move to the line above because
`Number(undefined)` is 0, and having a printWidth of 0 breaks
all sorts of formatting.
github-actions bot pushed a commit that referenced this issue Nov 9, 2020
@semantic-release-bot
chore(release): 2.2.9 [skip ci]
e5b6503 
## [2.2.9](v2.2.8...v2.2.9) (2020-11-09)

### Bug Fixes

* **#196:** fix prettier unspecified printWidth ([2c327c8](2c327c8)), closes [#195](#195)
@NullVoxPopuli NullVoxPopuli mentioned this issue Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NullVoxPopuli