Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanish translation activities 1-6 sql #494

Closed
wants to merge 1 commit into from

Conversation

agarayy
Copy link
Contributor

@agarayy agarayy commented Sep 17, 2024

No description provided.

Copy link
Member

@ozhang22 ozhang22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

hide_boxes();
} else {
// If incorrect, give alert
alert("Try Again, Space Cadet!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All text inside alert() needs to be translated

<script type="text/javascript" src="../default/_default.js"></script>
<script type="text/javascript" src="../default/_type.js"></script>
<script type="text/javascript" src="_activity1.js"></script>
<p style="text-align: center;"><iframe width="560" height="315" src="https://www.youtube.com/embed/hUTKI3AHJ1s" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all Youtube embed - we don't need them

<div style="clear: both;"></div>

<!-- Enter button -->
<button class="button button1" onclick="check()">Enter</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anywhere you see Enter or ERROR INVALID INPUT, please translate

if(input == ans1)
{
green(input);
document.getElementById("story").innerHTML = "Now we know how many guests will be attending! Let's choose what food to bring to the party!";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any strings beside .innerHTML = needs to be translated

</table>

<div id="text" style="visibility:hidden">
<h3> Ahora que sabes donde esta el Planeta de la Diversión, podemos encontrar mas información sobre este e ignorar a otros planetas. that you know where the Planet of Fun is, we can find more information about it and ignore the other planets. ¡Vamos al Planeta de la Diversión! </h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix translation - there's some English left

@ozhang22
Copy link
Member

Closing as contents have been incorporated into #488

@ozhang22 ozhang22 closed this Sep 18, 2024
@ozhang22 ozhang22 deleted the SQL-spanish-translation-1-6 branch September 20, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants