Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackathon24] Translation: SQL workshop in Spanish #488

Merged
merged 15 commits into from
Sep 18, 2024

Conversation

marianachavmed
Copy link
Contributor

Copying the SQL folder for Spanish and doing half translation (activities 7-12, default and syntax_explanation folders).
Activities 1-6 will be completed by Alejandra Garay

@ozhang22
Copy link
Member

@marianachavmed will Alejandra create a separate PR for activities 1-6 or will you be sharing this branch?

content/espanol/sql_workshop/activity10/_index.md Outdated Show resolved Hide resolved
<link rel="stylesheet" href="_activity10.css" type="text/css"></link>
<script type="text/javascript" src="_activity10.js"></script>

<p style="text-align: center;"><iframe width="560" height="315" src="https://www.youtube.com/embed/UCxPAE0xw3I" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the activity pages feel free to delete the youtube embed as it will not apply to the spanish workshop for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

content/espanol/sql_workshop/activity1/_activity1.js Outdated Show resolved Hide resolved
content/espanol/sql_workshop/activity12/_activity12.js Outdated Show resolved Hide resolved
content/espanol/sql_workshop/activity9/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@ozhang22 ozhang22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

content/espanol/sql_workshop/activity12/_activity12.js Outdated Show resolved Hide resolved
content/espanol/sql_workshop/activity11/_activity11.js Outdated Show resolved Hide resolved
content/espanol/sql_workshop/activity11/_activity11.js Outdated Show resolved Hide resolved
content/espanol/sql_workshop/activity10/_activity10.js Outdated Show resolved Hide resolved
content/espanol/sql_workshop/basics_activity/_index.md Outdated Show resolved Hide resolved
content/espanol/sql_workshop/activity8/_activity8.js Outdated Show resolved Hide resolved
@marianachavmed marianachavmed changed the title [Hackathon24] Translation: Half translation of SQL workshop in Spanish [Hackathon24] Translation: SQL workshop in Spanish Sep 17, 2024
@marianachavmed
Copy link
Contributor Author

@oliver-zhang-neuvo merged Alejandra's branch into mine, and addressed the comments you added in her PR:https://github.com/NuevoFoundation/workshops/pull/488

Can you see the changes, review and approve this PR instead? I can mark the other one as "draft"

@ozhang22 ozhang22 merged commit 2c338cf into master Sep 18, 2024
3 checks passed
@ozhang22 ozhang22 deleted the marianach/spanish-sql branch September 20, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants