RebortAbuse And LicenseReportVisiblity fixes #1770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Update the index for all versions | ||
| foreach(Package packageVersion in packageRegistration.Packages) | ||
| _indexingService.UpdatePackage(packageVersion); |
There was a problem hiding this comment.
Use "{}" please, even with a single statement body we prefer to use "{}" :)
There was a problem hiding this comment.
Thanks, will make a note of it going forward.
|
@bhuvak can you remove the package version fix and push a new copy of the branch without it so I can merge this in to the I6 QA deployment? |
|
Closing this request as the required portions of it are ported to dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724 and #1586
#1724 :
Clubbed "package has a bug" and "package failed to install" to one single reason. When this option is chosen an error message will be popped out and all other fields will be disabled.
Manually tested the below:
No easy way to supress Friendly License reports across all versions of a package #1586