This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
[C2R 2] Add registration comparer to compare two registration hives #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
cristinamanum,
skofman1,
dannyjdev and
zhhyu
loic-sharma
reviewed
Jan 4, 2020
loic-sharma
reviewed
Jan 4, 2020
src/NuGet.Jobs.RegistrationComparer/RegistrationComparerCommand.cs
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 4, 2020
src/NuGet.Jobs.RegistrationComparer/RegistrationComparerCollectorLogic.cs
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 4, 2020
joelverhagen
added a commit
that referenced
this pull request
Jan 6, 2020
joelverhagen
force-pushed
the
jver-c2r-cmp
branch
from
8cb7480 to
3ea0f87
Compare
loic-sharma
reviewed
Jan 6, 2020
loic-sharma
reviewed
Jan 6, 2020
loic-sharma
approved these changes
Jan 6, 2020
ryuyu
approved these changes
Jan 7, 2020
joelverhagen
force-pushed
the
jver-c2r-lightning-dep
branch
from
97afab3 to
68f7b9a
Compare
joelverhagen
force-pushed
the
jver-c2r-cmp
branch
from
3ea0f87 to
69bdcc7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically is a generic JSON document comparer with some normalization logic to handle known differences. These known differences are either by design or quirks.
My goal was NOT to make super re-usable or high performance code. Instead, the goal is to find differences in the two implementations. The
JsonComparerclass code found all of the problems mentioned inNormalizers.cs, so I am confident in the results.Progress on NuGet/NuGetGallery#7741.
Depends on #728.