This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
[C2R 1] Update Lightning to support the new Catalog2Registration with -driver #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
skofman1,
dannyjdev and
zhhyu
December 20, 2019 21:18
joelverhagen
force-pushed
the
jver-c2r-job-dep
branch
from
December 27, 2019 21:54
82741c8
to
b350edf
Compare
joelverhagen
added a commit
that referenced
this pull request
Dec 27, 2019
joelverhagen
force-pushed
the
jver-c2r-lightning
branch
from
December 27, 2019 21:55
428e27d
to
97afab3
Compare
joelverhagen
changed the title
[C2R 9] Update Lightning to support the new Catalog2Registration with -driver
Update Lightning to support the new Catalog2Registration with -driver
Dec 27, 2019
joelverhagen
changed the title
Update Lightning to support the new Catalog2Registration with -driver
[C2R 1] Update Lightning to support the new Catalog2Registration with -driver
Jan 3, 2020
loic-sharma
reviewed
Jan 6, 2020
loic-sharma
reviewed
Jan 6, 2020
loic-sharma
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I would recommend getting a review from someone who is more familiar with lightning
agr
reviewed
Jan 7, 2020
joelverhagen
added a commit
that referenced
this pull request
Jan 7, 2020
joelverhagen
force-pushed
the
jver-c2r-lightning
branch
from
January 7, 2020 00:49
6a83487
to
7bf37d2
Compare
agr
reviewed
Jan 7, 2020
agr
approved these changes
Jan 7, 2020
joelverhagen
force-pushed
the
jver-c2r-lightning
branch
from
January 7, 2020 01:12
7bf37d2
to
68f7b9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address NuGet/NuGetGallery#7740
Depends on #727