This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Copy NuGet.Protocol.Catalog from Samples repository #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
dtivel,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
joelverhagen
force-pushed
the
jver-models
branch
from
4375071 to
65e7aea
Compare
joelverhagen
added a commit
that referenced
this pull request
Nov 14, 2018
| </PropertyGroup> | ||
| <Import Project="$(SignPath)\sign.targets" Condition="Exists('$(SignPath)\sign.targets')" /> | ||
| <Import Project="$(SignPath)\sign.microbuild.targets" Condition="Exists('$(SignPath)\sign.microbuild.targets')" /> | ||
| <Import Project="..\..\sign.thirdparty.targets" /> |
There was a problem hiding this comment.
I would double check that all of the dependencies of this project are in the third-party list. May want to kick off a release build on this feature branch just to make sure that Extract and Verify Artifacts succeeds.
There was a problem hiding this comment.
I forgot MicroBuild. Should be good now.
loic-sharma
approved these changes
Nov 14, 2018
joelverhagen
force-pushed
the
jver-models
branch
from
7cc63b7 to
d136f6e
Compare
joelverhagen
added a commit
that referenced
this pull request
Nov 14, 2018
joelverhagen
force-pushed
the
jver-models
branch
from
d136f6e to
791f129
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address NuGet/NuGetGallery#6666.
This is just a simple copy from Samples repository. I had to move from SDK-based project to legacy .csproj which means it no longer targets .NET Standard 1.3 😢. I did not want to introduce SDK-based projects are part of this effort.
This code is already used by package lag monitor.