This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Convert CollectCdnLogs jobs to JsonConfig #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agr
approved these changes
Nov 28, 2018
xavierdecoster
approved these changes
Nov 29, 2018
chenriksson
force-pushed
the
chenriks-legacy
branch
from
2bc5079 to
497d470
Compare
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Convert CollectCdnLogs jobs to JsonConfig
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: https://github.com/NuGet/Engineering/issues/1936
I didn't realize that @xavierdecoster was already porting the
CollectAzureCdnLogsto JSON config (#679). We discussed either having me PR into his feature branch, or replacing his PR - I'm fine with either.In addition to
CollectAzureCdnLogs, this PR also portsCollectAzureChinaCdnLogstoJsonConfigurationJob. The intention is to have all jobs (NuGet.Jobs, NuGet.Internal.Jobs) using JSON config to simplify the new job deployments.