-
Notifications
You must be signed in to change notification settings - Fork 21
Ensure Stats.CollectAzureCdnLogs gets latest KeyVault secrets on every iteration #679
Conversation
f1e770e
to
083f9e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change the FTP password while the job is running it's going to crash and reload the new password when it comes back up, right? |
Yep, that's the idea. |
@xavierdecoster Didn't realize this included change to JSON configuration... had planned on doing this for job deployment changes (see 2bc5079). One question - why not use JsonConfigurationJob, like other jobs in this repo? |
@chenriksson I figured changing to JSON config would make the fix easier, and make the job more consistent at once :) I was unaware of the |
@xavierdecoster As part of SQL AAD work, I moved As part of the work for job deployments, @ryuyu and I want to migrate all jobs in this repo to JSON config and will be moving configurations to NuGetDeployment, with Octopus config replaced in source. So, Let me know if you want more details. Otherwise, I'll hold off on my changes to this job and follow your lead. |
return value; | ||
} | ||
|
||
throw new ArgumentException("Job parameter for Azure CDN Platform is invalid. Allowed values are: HttpLargeObject, HttpSmallObject, ApplicationDeliveryNetwork, FlashMediaStreaming."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string.Join(", ", Enum.GetValues(typeof(AzureCdnPlatform)))
instead of listing the values verbatim?
Closing. New PR #690 |
[ReleasePrep][2019.10.17]RI of dev into master
[ReleasePrep][2019.10.17]RI of dev into master
Fixes https://github.com/NuGet/Engineering/issues/1842