This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Use SQL AAD for DEV Validation connections #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skofman1
approved these changes
Nov 6, 2018
chenriksson
force-pushed
the
chenriks-sqlaad-nonval
branch
from
23e4dcd to
b38fa3e
Compare
loic-sharma
reviewed
Nov 6, 2018
| }, | ||
| "ValidationDb": { | ||
| "ConnectionString": "Data Source=tcp:#{Jobs.nuget.services.revalidate.DatabaseAddress};Initial Catalog=nuget-dev-validation;Integrated Security=False;User ID=$$Dev-ValidationDBWriter-UserName$$;Password=$$Dev-ValidationDBWriter-Password$$;Connect Timeout=30;Encrypt=True" | ||
| "ConnectionString": "Data Source=tcp:#{Jobs.nuget.services.revalidate.DatabaseAddress};Initial Catalog=nuget-dev-validation;Persist Security Info=False;Connect Timeout=30;Encrypt=True;TrustServerCertificate=False;Application Name=Revalidate;AadTenant=#{Deployment.Azure.ActiveDirectory.Tenant};AadClientId=#{Deployment.Azure.ActiveDirectory.ValidationDbWriter.ClientId};AadCertificate=$$dev-validationdb-writer$$" | ||
|
|
There was a problem hiding this comment.
There's an extra line here
There was a problem hiding this comment.
It seems this extra line was added to several other files too
There was a problem hiding this comment.
Thanks for catching - will fix.
loic-sharma
reviewed
Nov 6, 2018
| @@ -105,13 +105,13 @@ | |||
| <PrivateAssets>all</PrivateAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="NuGet.Services.Configuration"> | |||
| <Version>2.29.0</Version> | |||
| <Version>2.33.0-chenriks-sql-2183245</Version> | |||
There was a problem hiding this comment.
Don't forget to update to a master branch build :)
There was a problem hiding this comment.
Was handled in #653 ; I wanted these in separate commits, so I had PRs off my feature branch and will rebase.
loic-sharma
approved these changes
Nov 6, 2018
chenriksson
force-pushed
the
chenriks-sqlaad-val
branch
from
2e8753d to
8c2e079
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: https://github.com/NuGet/Engineering/issues/1618
(Separating Gallery and Validation DB config into separate commits)