This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Add more SQL AAD diagnostics #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
commented
Nov 6, 2018
| </PackageReference> | ||
| <PackageReference Include="NuGet.Services.Storage"> | ||
| <Version>2.29.0</Version> | ||
| <Version>2.33.0-chenriks-sql-2183245</Version> | ||
| </PackageReference> |
There was a problem hiding this comment.
Should be able to remove NuGet.Services.Storage, inherited from Validation.Common.Job
chenriksson
commented
Nov 6, 2018
| </PackageReference> | ||
| <PackageReference Include="NuGet.Services.Logging"> | ||
| <Version>2.27.0</Version> | ||
| <Version>2.33.0-chenriks-sql-2183245</Version> | ||
| </PackageReference> |
There was a problem hiding this comment.
Should be able to remove NuGet.Services.Configuration and NuGet.Services.Logging, inherited from NuGet.Jobs.Common
skofman1
approved these changes
Nov 6, 2018
chenriksson
force-pushed
the
chenriks-sql-diag
branch
from
b3d215f to
3ba9252
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2020
Merge branch 'dev' into master
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Merge branch 'dev' into master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: https://github.com/NuGet/Engineering/issues/1618
(will update to master build before merging)