-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NorCPM as an ESP component #565
base: noresm2_1_develop
Are you sure you want to change the base?
Conversation
modification in documentation on noresm2.0.6 release
…tch-2 Update new location for cmip6 data
changing processors configuration for f09_tn01254
Updates for noresm2.0.8
…tlist_allactive Rename test suite noresm_prealpha -> prealpha_noresm
* Add info about noresm2.0.8 in README.md file * Change BLOM tag to v1.4.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blcc - Looks fine to me.
Do you have write access, can you merge this yourself? Otherwise, I can do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really happy NorCPM is getting integrated into the NorESM code base. One thing I think we need to be able to maintain this (and help get it into newer versions of NorESM) is one or more regression test. I can help create the test entries, we just need to specify some information:
- Compset or compsets: E.g.,
NHISTNCPM
,NHISTNCPMfrc2
or both - Resolution: For testing, is the
f19_tn14
grid sufficient? - Test type: Should this test pass a restart test or just be able to run and reproduce baseline results?
- Test length: How long does the test need to run to fully test the NorCPM features?
- Any special setup (e.g.,
xmlchange
) or run-time (user_nl_<xxx>
) modifications?
Hi @gold2718 , |
@blcc, the changes look good. Can you address the testing questions above (in my review notes)? |
Both compsets are supported.
Yes, it sufficient.
The test is from startup run. And it can do continue run, reproduce identical results.
Since NorCPM assimilate daily SST and monthly temperature and salinity profile.
It is necessary to change the NINST and NTASKS in case. I'm still working on the document. |
@gold2718 |
I am not sure what I am looking for. I see slightly different files:
Which one should I refer to? The BjerknesCPU version seems to have more information but NorESM pulls from NorESMhub. I need to have enough information to add a regression test so that the NorCPM test gets run on a regular basis. |
@gold2718
|
@blcc |
@gold2718 |
@gold2718 |
Hi,
This PR adds NorCPM to Externals.cfg and compsets (NHISTNCPM, NHISTNCPMfrc2).
Thanks,
Ping-Gin