Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NorCPM as an ESP component #565

Open
wants to merge 21 commits into
base: noresm2_1_develop
Choose a base branch
from

Conversation

blcc
Copy link
Contributor

@blcc blcc commented Sep 27, 2024

Hi,
This PR adds NorCPM to Externals.cfg and compsets (NHISTNCPM, NHISTNCPMfrc2).

Thanks,
Ping-Gin

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blcc - Looks fine to me.
Do you have write access, can you merge this yourself? Otherwise, I can do this.

Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really happy NorCPM is getting integrated into the NorESM code base. One thing I think we need to be able to maintain this (and help get it into newer versions of NorESM) is one or more regression test. I can help create the test entries, we just need to specify some information:

  • Compset or compsets: E.g., NHISTNCPM, NHISTNCPMfrc2 or both
  • Resolution: For testing, is the f19_tn14 grid sufficient?
  • Test type: Should this test pass a restart test or just be able to run and reproduce baseline results?
  • Test length: How long does the test need to run to fully test the NorCPM features?
  • Any special setup (e.g., xmlchange) or run-time (user_nl_<xxx>) modifications?

cime_config/config_compsets.xml Outdated Show resolved Hide resolved
Externals.cfg Outdated Show resolved Hide resolved
@blcc
Copy link
Contributor Author

blcc commented Sep 30, 2024

Hi @gold2718 ,
I updated the PRs (NorESM and cime). Can you have a look?
Thanks,
Ping-Gin

@gold2718
Copy link

@blcc, the changes look good. Can you address the testing questions above (in my review notes)?

@blcc
Copy link
Contributor Author

blcc commented Sep 30, 2024

I am really happy NorCPM is getting integrated into the NorESM code base. One thing I think we need to be able to maintain this (and help get it into newer versions of NorESM) is one or more regression test. I can help create the test entries, we just need to specify some information:

* Compset or compsets: E.g., `NHISTNCPM`, `NHISTNCPMfrc2` or both

Both compsets are supported.

* Resolution: For testing, is the `f19_tn14` grid sufficient?

Yes, it sufficient.
For now NorCPM only modify ocean component. f09_tn14 should be able to run.
However, we can add the "sci. supported" back after more validations.

* Test type: Should this test pass a restart test or just be able to run and reproduce baseline results?

The test is from startup run. And it can do continue run, reproduce identical results.

* Test length: How long does the test need to run to fully test the NorCPM features?

Since NorCPM assimilate daily SST and monthly temperature and salinity profile.
Technical test can be only 1 month. For scientific validations, it will be good to have 20 model year test.

* Any special setup (e.g., `xmlchange`) or run-time (`user_nl_<xxx>`) modifications?

It is necessary to change the NINST and NTASKS in case. I'm still working on the document.

@blcc
Copy link
Contributor Author

blcc commented Oct 8, 2024

@gold2718
Hi, I updated the README.md with an test script in norcpm_esp repo.
Do you think it is sufficient for current state?

@gold2718
Copy link

@gold2718 Hi, I updated the README.md with an test script in norcpm_esp repo. Do you think it is sufficient for current state?

I am not sure what I am looking for. I see slightly different files:

Which one should I refer to? The BjerknesCPU version seems to have more information but NorESM pulls from NorESMhub. I need to have enough information to add a regression test so that the NorCPM test gets run on a regular basis.

@blcc
Copy link
Contributor Author

blcc commented Oct 10, 2024

@gold2718
You're right. I should keep only one of them.
I'll remove the BjerknesCPU one later.

I am not sure what I am looking for. I see slightly different files:

* From: [BjerknesCPU](https://github.com/BjerknesCPU/norcpm_esp/blob/main/README.md)

* From: [NorESMhub](https://github.com/NorESMhub/norcpm_esp/blob/main/README.md)

Which one should I refer to? The BjerknesCPU version seems to have more information but NorESM pulls from NorESMhub. I need to have enough information to add a regression test so that the NorCPM test gets run on a regular basis.

@gold2718
Copy link

@blcc
What version of CIME are you using? I keep getting errors when trying to run a case with NorCPM.

@blcc
Copy link
Contributor Author

blcc commented Oct 11, 2024

@gold2718
This is strange. I'll test again to see what happened.

@blcc
Copy link
Contributor Author

blcc commented Oct 11, 2024

@gold2718
I fixed few typo in test script.
And it need the PR of cime
NorESMhub/cime#83
Which add NorCPM as to one of the ESP component in cime/config/config_files.xml.

@gold2718 gold2718 changed the base branch from noresm2 to noresm2_1_develop October 26, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

7 participants