Fix depricated hysteris_sweep file #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function were using undefined (old) function and assumed old datastructures add tests for hysteresis_sweep functions
5 tasks
logging event can be turned of on demand. This behaviour is favorable for when working on clusters etc.
not phase space itself
|
This is ready for merge after review |
jdelpino
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft
fix the hysteris_sweep.jl file as most everything was depricated. Also moved file to TimeEvolution module as it best that all code that uses OrdinaryDiffEq is in one Module.
I would also like to add Require such that the TimeEvolution only is loaded whenOrdinarDiffEq. <\del>