alsa-utils: fix wrapper shebang when cross-compiling

[lopsided98]

Motivation for this change

The alsa-info.sh wrapper had build bash as a shebang when cross-compiling. This can be fixed by making makeWrapper a buildInput.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

cc @Ericson2314 @AndersonTorres

[AndersonTorres]

I am curious. Why putting makeWrapper as a buildInput solves it? makeWrapper definitely is not to be a buildInput...

[Ericson2314]

Per

nixpkgs/pkgs/top-level/all-packages.nix

Line 458 in 0794fb0

makeWrapper = makeSetupHook { deps = [ dieHook ]; substitutions = { shell = pkgs.runtimeShell; }; }

nativeBuildInputs should give you the true runtime shell, and depsBuildBuild should give you the build-time shell.

[lopsided98]

No, runtimeShell runs on the host platform for a given package set. When makeWrapper is a nativeBuildInput, its host platform is bmon's build platform. You can verify this by evaluating pkgsCross.<platform>.buildPackages.runtimeShell.

The only way I can see to make it work as a nativeBuildInput is to use shell = pkgs.targetPackages.runtimeShell. On the other hand, that would break it if it was used as a buildInput.

This is not the first time this fix has been needed: #58305

[Ericson2314]

Oh my bad, but it definitely should be shell = pkgs.targetPackages.runtimeShell.