dhcp: cross compile #58305
Merged
dhcp: cross compile #58305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
added
the
6.topic: cross-compilation
illegalprime
force-pushed
the
dhcp-cross
branch
from
e981b1e to
cbda11b
Compare
| @@ -57,6 +63,8 @@ stdenv.mkDerivation rec { | |||
| substituteInPlace configure --replace "/usr/bin/file" "${file}/bin/file" | |||
| sed -i "includes/dhcpd.h" \ | |||
| -"es|^ *#define \+_PATH_DHCLIENT_SCRIPT.*$|#define _PATH_DHCLIENT_SCRIPT \"$out/sbin/dhclient-script\"|g" | |||
|
|
|||
| export AR=$(${buildPackages.which}/bin/which $AR) | |||
There was a problem hiding this comment.
I think the better way to do this is:
export AR=${stdenv.cc.bintools.bintools}/bin/${stdenv.cc.targetPrefix}ar
illegalprime
force-pushed
the
dhcp-cross
branch
from
cbda11b to
f9a4a6e
Compare
|
updated |
|
I think this should go to staging as well |
matthewbauer
approved these changes
Apr 2, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cross compile dhcp,
dhclientstill fails becausemakeWrapperwraps some scripts in the wrongbashmakeWrapperto be inbuildInputsfixed this.The only note here is that when cross compiling DHCP wants to know the full path of a random device, on linux it's likely going to be
/dev/random, but maybe this is hacky. not sure!Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)