Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airwindows: init at unstable-2020-08-24 #89084

Closed
wants to merge 2 commits into from
Closed

airwindows: init at unstable-2020-08-24 #89084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57c8fb
airwindows: init at 2020-05-25
magnetophon May 27, 2020
e277c52
airwindows: unstable-2020-05-25 -> unstable-2020-08-24
magnetophon Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions pkgs/applications/audio/airwindows/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
{ stdenv, fetchFromGitHub, requireFile, unzip, cmake }:

stdenv.mkDerivation rec {
name = "airwindows-${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is automatically constructed from pname-version.

Suggested change
name = "airwindows-${version}";
pname = "airwindows";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OPNA2608 I seem to have messed up the push, sorry.
I'm working on getting the new fork to build, and once will than push the fixes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some trouble pushing to this branch, so I made #123954

version = "2020-08-24";

src = fetchFromGitHub {
owner = "airwindows";
repo = "airwindows";
rev = "3022096e8c0e82abdefbc7cae240dd8d0cac5147";
sha256 = "1pvnzl486630qhdc6qjgddglgq89lxjh2kgnyl4q2ia9mn36iisx";
};

vst-sdk = stdenv.mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this duplicated over in the already existing airwave distribution, just in a different version.

nixpkgs/pkgs/applications/audio/airwave/default.nix

Lines 16 to 26 in 84cf00f

vst-sdk = stdenv.mkDerivation rec {
name = "vstsdk368_08_11_2017_build_121";
src = requireFile {
name = "${name}.zip";
url = "http://www.steinberg.net/en/company/developers.html";
sha256 = "e0f235d8826d70f1ae0ae5929cd198acae1ecff74612fde5c60cbfb45c2f4a70";
};
nativeBuildInputs = [ unzip ];
installPhase = "cp -r . $out";
meta.license = stdenv.lib.licenses.unfree;
};

And a PR with the SDK part updated to the very version you're requiring here, #82380

I think I'd rather see this as a separate derivation, but there were objections to that a long while ago (#10006). I wonder if these still exist? Just commenting on this situation, not requesting any change in particular.

name = "vstsdk366_27_06_2016_build_61";
src = requireFile {
name = "${name}.zip";
url = "https://www.steinberg.net/sdk_downloads/vstsdk366_27_06_2016_build_61.zip";
sha256 = "05gsr13bpi2hhp34rvhllsvmn44rqvmjdpg9fsgfzgylfkz0kiki";
};
nativeBuildInputs = [ unzip ];
installPhase = "cp -r . $out";
};

airwindows-ports = stdenv.mkDerivation rec {
name = "airwindows-ports";
src = fetchFromGitHub {
owner = "ech2";
repo = "airwindows-ports";
rev = "0.4.0";
sha256 = "1ya4qbc63sb52nzisdapsydrnnpqnjsl5kgxibbr3dxf32474g89";
};
installPhase = "cp -r . $out";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the unfree license here and keep the main derivation MIT.

Suggested change
};
meta.license = stdenv.lib.licenses.unfree;
};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I'm working on it.
I think you mean line 23, in vst-sdk, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err yea, apologies.


nativeBuildInputs = [ cmake ];

patchPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
patchPhase = ''
postPatch = ''

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some trouble pushing to this branch, so I made #123954

cd plugins/LinuxVST
rm build/CMakeCache.txt
mkdir -p include/vstsdk
cp -r ${airwindows-ports}/include/vstsdk/CMakeLists.txt include/vstsdk/
cp -r ${vst-sdk}/pluginterfaces include/vstsdk/pluginterfaces
cp -r ${vst-sdk}/public.sdk/source/vst2.x/* include/vstsdk/
chmod -R 777 include/vstsdk/pluginterfaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
chmod -R 777 include/vstsdk/pluginterfaces
chmod -R 755 include/vstsdk/pluginterfaces

'';

installPhase = ''
for so_file in *.so; do
install -vDm 644 $so_file -t "$out/lib/lxvst"
done;
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

description = "Handsewn bespoke linuxvst plugins";
homepage = http://www.airwindows.com/airwindows-linux/;
magnetophon marked this conversation as resolved.
Show resolved Hide resolved
# airwindows is mit, but the vst sdk is unfree
license = licenses.unfree;
magnetophon marked this conversation as resolved.
Show resolved Hide resolved
platforms = platforms.linux;
maintainers = [ maintainers.magnetophon ];
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19309,6 +19309,8 @@ in

airwave = callPackage ../applications/audio/airwave { };

airwindows = callPackage ../applications/audio/airwindows { };

akira-unstable = callPackage ../applications/graphics/akira { };

alembic = callPackage ../development/libraries/alembic {};
Expand Down