Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm{6..10}/compiler-rt: fix compilation on Darwin #87528

Merged
merged 1 commit into from
May 20, 2020
Merged

llvm{6..10}/compiler-rt: fix compilation on Darwin #87528

merged 1 commit into from
May 20, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented May 10, 2020 •
edited
Loading

Motivation for this change

The patch #85945 seems to have broken things. Correcting the fallout.

See #85945 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 10, 2020
@ggreif ggreif mentioned this pull request May 10, 2020
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 10, 2020
@ggreif
Copy link
Contributor Author

ggreif commented May 10, 2020

@GrahamcOfBorg build llvmPackages_6.compiler-rt llvmPackages_7.compiler-rt llvmPackages_8.compiler-rt llvmPackages_9.compiler-rt llvmPackages_10.compiler-rt

@ggreif ggreif marked this pull request as ready for review May 10, 2020 19:50
@ggreif ggreif requested a review from matthewbauer as a code owner May 10, 2020 19:50
@doronbehar doronbehar mentioned this pull request May 10, 2020
Merged
10 tasks
@ggreif ggreif changed the title compiler-rt{6..10}: fix compilation on Darwin llvm/compiler-rt{6..10}: fix compilation on Darwin May 10, 2020
@ggreif ggreif changed the title llvm/compiler-rt{6..10}: fix compilation on Darwin llvm{6..10}/compiler-rt: fix compilation on Darwin May 10, 2020
@matthewbauer matthewbauer changed the base branch from master to staging May 11, 2020 15:38
@matthewbauer matthewbauer changed the base branch from staging to master May 11, 2020 15:38
@ggreif ggreif mentioned this pull request May 20, 2020
Merged
10 tasks
@DieGoldeneEnte
Copy link
Contributor

This should be merged into staging not master :)

@ggreif ggreif changed the base branch from master to staging May 20, 2020 17:47
@DieGoldeneEnte
Copy link
Contributor

ofborg labels this as 5001+ packages for darwin need to be rebuild (basically everything c/c++ I think).

@ggreif
Copy link
Contributor Author

ggreif commented May 20, 2020

Certainly, my mind was on another PR :-)

@ggreif
Copy link
Contributor Author

ggreif commented May 20, 2020

@matthewbauer What is blocking the merge of this guy?

@matthewbauer
Copy link
Member

Any idea why the checks are failing? It doesn’t look related to the PR so may be a staging issue.

@ggreif
Copy link
Contributor Author

ggreif commented May 20, 2020

@GrahamcOfBorg build llvmPackages_6.compiler-rt llvmPackages_7.compiler-rt llvmPackages_8.compiler-rt llvmPackages_9.compiler-rt llvmPackages_10.compiler-rt

@ggreif
Copy link
Contributor Author

ggreif commented May 20, 2020

@matthewbauer the error is

autoreconf: running: /nix/store/k8nj00yrqlcf7wy2gj5ybz6nk7ki4ylv-autoconf-2.69/bin/autoconf --force
configure.ac:136: error: possibly undefined macro: AC_MSG_FAILURE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:310: error: possibly undefined macro: AC_CHECK_LIB
autoreconf: /nix/store/k8nj00yrqlcf7wy2gj5ybz6nk7ki4ylv-autoconf-2.69/bin/autoconf failed with exit status: 1
builder for '/nix/store/k1wkxxar19dgqwna2pl0ra9rd047mijh-libarchive-3.4.2.drv' failed with exit code 1

which I have never seen before. Seems unrelated, but scary nevertheless.

@matthewbauer matthewbauer merged commit bbf0790 into NixOS:staging May 20, 2020
@ggreif ggreif deleted the ggreif/compiler-rt branch May 20, 2020 19:05
@ggreif ggreif mentioned this pull request Jun 1, 2020
Closed
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggreif @DieGoldeneEnte @matthewbauer @rrbutani