bundlerApp: Set up passthru properly #62971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The manual documents both bundlerEnv and bundlerApp as providing
env
andwrappedRuby
attributes on the resulting derivations. However only bundlerEnv actually had these attributes. Update bundlerApp to provide the same passthru that bundlerEnv does.Since bundlerApp already let the user provide their own passthru, I've chosen to allow that to take precedence over the default passthru, meaning the user may overwrite
env
orwrappedRuby
with their own attributes if they choose to do so.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)I have not actually tested the impact of this change on the nixpkgs repository. It shouldn't result in rebuilding any
bundlerApp
packages as it only affectspassthru
. I did test the one package I actually care about (the package whose environment I want access to in anix-shell
). Given that any manually-providedpassthru
argument will overwrite what I'm adding, this change should be purely additive.