asciidoctor: 1.5.7.1 -> 2.0.10

[michaelpj]

Motivation for this change

There has been a new major version, so it seems good to upgrade.

I had to drop two plugins:

• asciidoctor-latex seems dead, and hasn't had any commits since 2015.
• asciidoctor-bespoke also hasn't been updated for over a year, and
  doesn't seem to be compatible with the new version.

@yacinehmito

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[worldofpeace]

commit msg should be

asciidoctor: 1.5.7.1 -> 2.0.10

[michaelpj]

Commit message fixed.

[yacinehmito]

I have not tested (not running a NixOS system currently) but it LGTM 👍 .

Also, small question: why did you remove asciidoctor-latex?

[michaelpj]

Also, small question: why did you remove asciidoctor-latex?

Ah, I said why I didn't feel bad about dropping it, but not why I had to: it specifies an old version of asciidoctor in its gemspec. I don't know if there's a way to override it's version constraints, but I couldn't get bundix to work for me with it included. Also, I think the internals of asciidoctor changed a fair bit in 2.0, which is likely to affect plugins that aren't explicitly updated.

[worldofpeace]

Looks good to me, is there someway I can use this nix expression to run their tests?

• https://github.com/asciidoctor/asciidoctor/blob/master/Rakefile

[michaelpj]

No obviously. I tried installing rake and using nix-shell on it, but it didn't work. Nor does it have an .env attribute as the manual says it should...

[worldofpeace]

I tried installing rake and using nix-shell on it, but it didn't work. Nor does it have an .env attribute as the manual says it should...

Looks like that's WIP being fixed #62971 ✨

[michaelpj]

Do you want to wait to try that out or can we merge this? I've tested the executables by hand and they seem to work.

[worldofpeace]

That sounds fine, merging now.