Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/colord: don't run as root #58458

Merged
merged 1 commit into from
Mar 30, 2019
Merged

nixos/colord: don't run as root #58458

merged 1 commit into from
Mar 30, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Implementing one of my suggested improvements in #57840

Things done

Built a vm and checked that at least the services were running.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from infinisil as a code owner March 27, 2019 20:15
@worldofpeace worldofpeace requested a review from jtojnar March 27, 2019 20:16
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 27, 2019
infinisil
infinisil approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you squash?

@worldofpeace
Copy link
Contributor Author

Yep, doing so now.

@worldofpeace
nixos/colord: don't run as root
f22fbe1 
Using systemd.packages because there's
a system colord service and colord-session user service
included.
@infinisil infinisil merged commit 81e2fb5 into NixOS:master Mar 30, 2019
@worldofpeace worldofpeace deleted the colord/no-root branch March 30, 2019 03:42
@worldofpeace worldofpeace mentioned this pull request May 18, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@worldofpeace @infinisil @GrahamcOfBorg