Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colord: 1.4.2 -> 1.4.4 #57840

Merged
merged 2 commits into from
Mar 18, 2019
Merged

colord: 1.4.2 -> 1.4.4 #57840

merged 2 commits into from
Mar 18, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Mar 18, 2019

Notable changes
  • multiple outputs
  • enable all docs
  • installed tests
News Items

https://github.com/hughsie/colord/blob/1.4.3/NEWS
https://github.com/hughsie/colord/blob/1.4.4/NEWS

Possible improvements
  1. Normal tests should probably be enabled
  2. NixOS test for the installed tests
  3. Possibly have colord user for the daemon instead of running as root
    This would probably be a good follow up.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from jtojnar March 18, 2019 02:56
"-Denable-docs=false"
"-Dinstalled_tests=true"
"-Dlibcolordcompat=true"
"-Dsane=true"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remember if there were problems with sane here.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 18, 2019
];

nativeBuildInputs = [ meson pkgconfig vala_0_40 ninja gettext libxml2 gobject-introspection makeWrapper ];
nativeBuildInputs = [
docbook_xsl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I should have probably ported the api docs to Docbook 5 too.

@jtojnar
Copy link
Member

jtojnar commented Mar 18, 2019

The installed test for NixOS should be easy to do: #34987

The separate user sounds good but I agree that it is out of scope of this PR.

@worldofpeace
Copy link
Contributor Author

Had to add a patch for the tests.

I've ran them, think it was a success.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 18, 2019
@worldofpeace
Copy link
Contributor Author

Just saw this pr #56504
Interesting, don't like how it tries to access a network resource.

@worldofpeace worldofpeace merged commit c94f6f2 into NixOS:master Mar 18, 2019
@worldofpeace worldofpeace deleted the colord/bump branch March 18, 2019 13:25
@worldofpeace worldofpeace mentioned this pull request Mar 27, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants