nixos/elastic-apm-server: init #57995
Conversation
|
shas should be changed when #57992 gets merged. |
GrahamcOfBorg
added
6.topic: nixos
betaboon
force-pushed
the
elastic-apm-server
branch
from
2a21f3e
to
775f0b0
Compare
| sha256 = shas."${stdenv.hostPlatform.system}" or (throw "Unknown architecture"); | ||
| }; | ||
|
|
||
| buildInputs = [ makeWrapper ]; |
There was a problem hiding this comment.
makeWrapper isn't used as far as I can see.
| meta = { | ||
| description = "Open Source Application Performance Monitoring"; | ||
| license = if enableUnfree then licenses.elastic else licenses.asl20; | ||
| platforms = platforms.unix; |
| installPhase = '' | ||
| mkdir -p $out/{bin,share} | ||
| cp apm-server $out/bin | ||
| cp -r apm-server.yml fields.yml kibana $out/share |
There was a problem hiding this comment.
These should be put into $out/share/apm-server instead
|
|
||
| src = fetchurl { | ||
| url = "https://artifacts.elastic.co/downloads/apm-server/${name}-${plat}-${arch}.tar.gz"; | ||
| sha256 = shas."${stdenv.hostPlatform.system}" or (throw "Unknown architecture"); |
There was a problem hiding this comment.
The error should also include the package name, something like "apm-server is not available on ${stdenv.hostPlatform.system}"
| inherit (builtins) elemAt; | ||
| info = splitString "-" stdenv.hostPlatform.system; | ||
| arch = elemAt info 0; | ||
| plat = elemAt info 1; |
There was a problem hiding this comment.
Should be about
arch = stdenv.hostPlatform.cpu.name;
plat = stdenv.hostPlatform.kernel.name;
|
|
||
| beatslib = import ./lib.nix { inherit lib pkgs; }; | ||
|
|
||
| mkApmServerConfig = cfg: { |
There was a problem hiding this comment.
No need to define functions when you only use them for one argument, just define the result directly.
| beatConfig = foldl' recursiveUpdate {} [ | ||
| (mkCommonBeatConfig cfg) | ||
| (mkBeatConfig cfg) | ||
| cfg.extraConfig |
There was a problem hiding this comment.
Since you're already doing something like that, I really suggest you do this instead: https://github.com/Infinisil/rfcs/blob/nixos-config/rfcs/0000-nixos-config.md#detailed-design, which will have a bunch of advantages
(ping @aanderse)
There was a problem hiding this comment.
Have opened an RFC since then for that: NixOS/rfcs#42
|
|
||
| preStart = '' | ||
| mkdir -p ${beatConfig.path.data} | ||
| mkdir -p ${beatConfig.path.logs} |
There was a problem hiding this comment.
Use systemd.tmpfiles for this instead
|
|
||
| { | ||
|
|
||
| mkCommonOptions = { name, defaults }: { |
There was a problem hiding this comment.
Unless I'm missing something here, you don't need to abstract this with a library file. Just write an option that you can set multiple times wherever you need it. Something like
{
options.services.beats = mkOption {
type = types.attrsOf (types.submodule ({ name, ... }: {
options = {
enable = true;
# ...
};
}));
};
}And then set services.beats.apm-server.enable = true; and such where you need an instance. This way you also won't duplicate all these options.
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
ryantm
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
ryantm
added
2.status: merge conflict
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Motivation for this change
I wanted to use elastic-apm-server together with a language-dependant agent.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)