-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds for pythonPackages.azure-mgmt-* #52550
Conversation
btw, if you want to reproduce the error, please do so with |
add pinned versions package-private azure-mgmt-compute 0.20.1 azure-mgmt-network 0.20.1 azure-mgmt-nspkg 1.0.0 azure-mgmt-resource 0.20.1 azure-mgmt-storage 0.20.0 NixOS#52550 NixOS/nixops#1065
It seems, the Haven't tested the fixes in this PR with the newer version, but should basically work ... |
add pinned versions package-private azure-mgmt-compute 0.20.1 azure-mgmt-network 0.20.1 azure-mgmt-nspkg 1.0.0 azure-mgmt-resource 0.20.1 azure-mgmt-storage 0.20.0 #52550 NixOS/nixops#1065
Unstable should probably be working towards updating to the most recent version, so marking as broken, instead of using the pinned version, like stable does. see #52550 see NixOS/nixops#1065 see #52547
add pinned versions package-private azure-mgmt-compute 0.20.1 azure-mgmt-network 0.20.1 azure-mgmt-nspkg 1.0.0 azure-mgmt-resource 0.20.1 azure-mgmt-storage 0.20.0 #52550 NixOS/nixops#1065 (cherry picked from commit 0c4d750)
This build failure was ported to stable: #55757 |
@bendlas this doesn't apply anymore, could you rebase? What else is preventing this from being merged? Does nixops work with the updated packages, or do we need to keep the private ones? |
Can do. AFAICT, we don't have any consumers, other than nixops, though.
Unfortunately, NixOS/nixops#1065 needs to be resolved first. |
Please add appropriate |
add pinned versions package-private azure-mgmt-compute 0.20.1 azure-mgmt-network 0.20.1 azure-mgmt-nspkg 1.0.0 azure-mgmt-resource 0.20.1 azure-mgmt-storage 0.20.0 NixOS#52550 NixOS/nixops#1065 (cherry picked from commit 0c4d750)
Don't merge until nixops is updated!EDIT Nixops has received a package-private, pinned version of
azure-mgmt-*
, so this can be merged at leisureMotivation for this change
Followup to the reverts in #52547
Revert the reverted updates and apply some build fixes on top
With this,nixops
still fails, because it can't work with these versions, so this will need to wait until nixops is updated:cc @olcai @FRidh