Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-mgmt-* packages don't build #52547

Closed
bendlas opened this issue Dec 19, 2018 · 7 comments
Closed

azure-mgmt-* packages don't build #52547

bendlas opened this issue Dec 19, 2018 · 7 comments
Assignees
Milestone

Comments

@bendlas
Copy link
Contributor

bendlas commented Dec 19, 2018

Issue description

I've already worked through the update, but let's revert for now, because the newer azure-mgmt-* packages also break nixops.

cc @olcai @FRidh

Steps to reproduce

$ nix-build <nixpkgs> -A pythonPackages.azure-mgmt-storage
...
configuring
sed: can't read azure/mgmt/storage/storagemanagement.py: No such file or directory
...
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this issue Dec 19, 2018
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this issue Dec 19, 2018
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this issue Dec 19, 2018
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this issue Dec 19, 2018
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this issue Dec 19, 2018
@bendlas
Copy link
Contributor Author

bendlas commented Dec 19, 2018

nox-review shows nixops and nixopsUnstable as the only dependencies, so I went ahead and pushed those reverts. I'll submit the updates as a separate PR.

@bendlas
Copy link
Contributor Author

bendlas commented Mar 3, 2019

@bendlas bendlas reopened this Mar 3, 2019
bendlas added a commit that referenced this issue Mar 3, 2019
Unstable should probably be working towards updating to the most
recent version, so marking as broken, instead of using the pinned
version, like stable does.

see #52550
see NixOS/nixops#1065
see #52547
bendlas added a commit that referenced this issue Mar 10, 2019
bendlas added a commit that referenced this issue Mar 10, 2019
see #52547

(cherry picked from commit 88d9ef9)
bendlas added a commit that referenced this issue Mar 10, 2019
@bendlas
Copy link
Contributor Author

bendlas commented Mar 10, 2019

fixed and backported to 19.03

@bendlas bendlas closed this as completed Mar 10, 2019
@bendlas bendlas added this to the 19.03 milestone Mar 10, 2019
@ocharles
Copy link
Contributor

I'm not convinced this is fixed in 19.03:

nix-build -E '(import (builtins.fetchTarball "https://github.com/NixOS/nixpkgs-channels/archive/5c52b25283a6cccca443ffb7a358de6fe14b4a81.tar.gz") {}).pythonPackages.azure-mgmt-storage'

these derivations will be built:
  /nix/store/6vq212gk8fgg7nhdirz08yi4kxx1qgrd-python2.7-azure-mgmt-storage-3.1.1.drv
building '/nix/store/6vq212gk8fgg7nhdirz08yi4kxx1qgrd-python2.7-azure-mgmt-storage-3.1.1.drv'...
unpacking sources
unpacking source archive /nix/store/59g39l0hp98b0hvicad16fgx2rjfpcax-azure-mgmt-storage-3.1.1.zip
source root is azure-mgmt-storage-3.1.1
setting SOURCE_DATE_EPOCH to timestamp 1546468640 of file azure-mgmt-storage-3.1.1/setup.cfg
patching sources
configuring
sed: can't read azure/mgmt/storage/storagemanagement.py: No such file or directory
builder for '/nix/store/6vq212gk8fgg7nhdirz08yi4kxx1qgrd-python2.7-azure-mgmt-storage-3.1.1.drv' failed with exit code 2
error: build of '/nix/store/6vq212gk8fgg7nhdirz08yi4kxx1qgrd-python2.7-azure-mgmt-storage-3.1.1.drv' failed

5c52b25 is (as far as I can see) the latest 19.03 channel revision.

@asymmetric
Copy link
Contributor

@ocharles hasn't landed in the channel yet:

preConfigure = ''
# Patch to make this package work on requests >= 2.11.x
# CAN BE REMOVED ON NEXT PACKAGE UPDATE
sed -i 's|len(request_content)|str(len(request_content))|' azure/mgmt/storage/storagemanagement.py
'';

@ocharles
Copy link
Contributor

Thanks, I did have a look at some files and could see some of the above commits had been cherry picked. I'm also surprised that it hasn't hit the channel despite being merged over a month ago?

@asymmetric
Copy link
Contributor

asymmetric commented Apr 15, 2019

I'm also confused, given how 5c52b25 is 6 days old and is in the channel.


EDIT: Oh I see, it has only actually landed in the release-19.03 branch 4 days ago.

adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants