-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: mass rebuild noop cleanups #47233
treewide: mass rebuild noop cleanups #47233
Conversation
02c09e0 (NixOS#44558) was reverted in c981787 but, as it turns out, it fixed an issue I didn't know about at the time: the values of `propagateDoc` options were (and now again are) inconsistent with the underlying things those wrappers wrap (see NixOS#46119), which was (and now is) likely to produce more instances of NixOS#43547, if not now, then eventually as stdenv changes. This patch (which is a simplified version of the original reverted patch) is the simplest solution to this whole thing: it forces wrappers to directly inspect the outputs of the things they are wrapping instead of making stdenv guess the correct values.
54282b9 tread carefuly to avoid a mass rebuild. This embraces the mass rebuild to clean things up.
2eb6867
to
9a7e87c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to give time for opinions, but LGTM.
9a7e87c
to
87c0206
Compare
Timed out, unknown build status on x86_64-linux (full log) Attempted: gcc7, libdaemon, linuxHeaders, llvm_5, newt, pkgconfig, stdenv, texinfo Partial log (click to expand)
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: gcc7, libdaemon, linuxHeaders, llvm_5, newt, pkgconfig, stdenv, texinfo Partial log (click to expand)
|
That rebase was a typo fix in a commit message. I don't see any others, so this now LGTM. |
Timed out, unknown build status on aarch64-linux (full log) Attempted: gcc7, libdaemon, linuxHeaders, llvm_5, newt, pkgconfig, stdenv, texinfo Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping |
Thanks!! Wonderful to see those TODOs purged :). |
Motivation for this change
First patch is the first patch of #46115 (which should also close #43547 again, but without the "controversial" second patch of #46115), second patch is a fixed edited version of #46127, the rest are trivial noop changes that cause mass rebuilds.
Things done
/cc @Ericson2314