stdenv: symlink propagated docs #44558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxij
force-pushed
the
stdenv/symlink-propagated-docs
branch
from
d389aff to
676d8e0
Compare
GrahamcOfBorg
added
10.rebuild-darwin-stdenv
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
I like the new parameter order, too. |
|
Failure on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
See discussion in NixOS#44516.
oxij
force-pushed
the
stdenv/symlink-propagated-docs
branch
from
676d8e0 to
02c09e0
Compare
|
It just struck me that this can be simplified even more with the changes I already made here. Dropped all explicit |
|
Ping. I just successfully built my whole Linux system on top of this change. I also doubt this version will break anything on Darwin as it now selects `propagateDoc` automagically.
I'd merge.
|
|
Sorry for no merge from me; I'm temporary unable to test on Darwin. Thanks @matthewbauer |
|
IMHO the correct fix is to use |
|
@edolstra can you elaborate why? I feel like it makes no difference semantically speaking but it's simpler.
|
|
I want to be able to do |
oxij
added a commit
to oxij/nixpkgs
that referenced
this pull request
Sep 23, 2018
02c09e0 (NixOS#44558) was reverted in c981787 but, as it turns out, it fixed an issue I didn't know about at the time: the values of `propagateDoc` options were (and now again are) inconsistent with the underlying things those wrappers wrap (see NixOS#46119), which was (and now is) likely to produce more instances of NixOS#43547, if not now, then eventually as stdenv changes. This patch (which is a simplified version of the original reverted patch) is the simplest solution to this whole thing: it forces wrappers to directly inspect the outputs of the things they are wrapping instead of making stdenv guess the correct values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This sidesteps the original problem of #43547 as suggested by @infinisil in #43547 (comment) and @dezgeg in #44516 (comment).
Things done
Things not done