libretro.mame: 2017-03-02 -> 2018-09-13 #47137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for fixing this! |
|
@GrahamcOfBorg build libretro.mame |
|
If it took hours on your machine it is likely to time out on ofborg .... |
|
Unexpected error: command failed with exit code 1 on aarch64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
|
OK, technically it didn't exactly time out, it decided to space out. |
|
@GrahamcOfBorg eval |
|
(eval checks could still be useful) |
|
Yea, I suspected it being too big for the bot. However having the checksum & evaluation checked once more is nice. The repo is over 1.6G :), I've built it three times today—it takes hours. |
|
Unexpected error: command failed with exit code 1 on aarch64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
|
Eval is through. I'm gonna cherry-pick this onto master/release unless there are any second thoughts. |
|
Can only improve current situation 😄 |
|
Unexpected error: command failed with exit code 1 on aarch64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
Fixes build of the MAME libretro core. Closes NixOS#47137. Signed-off-by: Christoph Hrdinka <[email protected]>
hrdinka
force-pushed
the
fix-libretro-mame
branch
from
91046c1 to
a83ee34
Compare
hrdinka
added a commit
that referenced
this pull request
Sep 21, 2018
Fixes build of the MAME libretro core. Closes #47137. Signed-off-by: Christoph Hrdinka <[email protected]>
hrdinka
added a commit
that referenced
this pull request
Sep 21, 2018
Fixes build of the MAME libretro core. Closes #47137. Signed-off-by: Christoph Hrdinka <[email protected]>
|
Unexpected error: command failed with exit code 1 on aarch64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: libretro.mame Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build of the libretro MAME core as reported on #47108.
It builds and works for me. The build time is quite insane and the change is a trivial update. Therefore I'll cherrypick onto master & release branch as soon as the build bot finishes.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)