Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark long-failing packages broken for 18.09 (2) #47108

Merged
merged 3 commits into from
Sep 25, 2018
Merged

Mark long-failing packages broken for 18.09 (2) #47108

merged 3 commits into from
Sep 25, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 21, 2018

Motivation for this change

ZHF #45960 . Continuation of #46385. I'll keep adding broken packages as I find them.

@xeji xeji added the 2.status: work-in-progress This PR isn't done label Sep 21, 2018
@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

cc respective maintainers:

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 21, 2018
@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

eztrace: cc maintainer @Fuuzetsu

@7c6f434c
Copy link
Member

acl2: I guess no point in waiting for release, and the patch that solves the immediate problem is not applicable directly to 8.0, and it doesn't look like they have many regressions, so a pre-release bump: de764e6

1 similar comment
@7c6f434c
Copy link
Member

acl2: I guess no point in waiting for release, and the patch that solves the immediate problem is not applicable directly to 8.0, and it doesn't look like they have many regressions, so a pre-release bump: de764e6

@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

@7c6f434c : thanks! Can I backport the fix to 18.09?

@7c6f434c
Copy link
Member

7c6f434c commented Sep 21, 2018 via email

@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

acl2: backported in d10c5b8

@hrdinka
Copy link
Contributor

hrdinka commented Sep 21, 2018

libretro.mame: I'm on it. It's currently compiling since hours, I'll commit a patch once it's finished.

@romildo romildo mentioned this pull request Sep 21, 2018
Closed
9 tasks
@kini
Copy link
Member

kini commented Sep 21, 2018

acl2: ACL2 devs just cut an 8.1 release a couple days ago, and @7c6f434c the commit you've designated as "8.0.post.2018.09.20" is actually after the 8.1 release. Why not just bump to 8.1? I haven't been following the build failures (sorry) but I imagine that whatever fix you needed from 531089336bb1734ff82c7b3b3fc05917451db770 is present in 8.1 as well.

@7c6f434c
Copy link
Member

7c6f434c commented Sep 21, 2018 via email

@kini
Copy link
Member

kini commented Sep 21, 2018

Huh, looks like I was even involved in fixing the build failure, back in May... my memory must be failing :P I should have cut a 8.0.post.2018.05.09 back then.

About GitHub releases/tags, one needs to check acl2-devel/acl2-devel, which is the repository mentioned in the nix derivation, rather than acl2/acl2 (yeah it's confusing). I'll sync git tags between the two repos soon.

@romildo romildo mentioned this pull request Sep 21, 2018
Merged
9 tasks
@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

monodevelop: cc @obadz

@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

Thank you @romildo for fixing enlightenment.rage!

@7c6f434c
Copy link
Member

OK, switched acl2 to 8.1 in 60b6d5f

@hrdinka hrdinka mentioned this pull request Sep 21, 2018
Closed
9 tasks
@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

acl2: picked 8.1 to 18.09 in fd69306

@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

(I'm just reverting these to keep track. Will cleanup before merge.)

@Fuuzetsu
Copy link
Member

eztrace: cc maintainer @Fuuzetsu

unable to do maintenance, feel free to do anything (disable)

@xeji
Copy link
Contributor Author

xeji commented Sep 24, 2018

eztrace was just fixed in #47282.
Out of the 7 packages added to this list, 4 have already been fixed. Awesome!

xeji added 3 commits September 25, 2018 11:59
@xeji
gtk-sharp-3_0: mark broken
395a152 
build has failed since 2018-04-28
no maintainer
@xeji
monodevelop: mark broken
6b4abb9 
build has failed since 2018-03-08
cc maintainer @obadz
@xeji
herqq: mark broken
9beaa6d 
- build fails with qt511 and qt59
  (it used to build with qt510 which is not available anymore)
- no nixpkgs maintainer
- upstream repo looks inactive, last commit a year ago
@xeji xeji changed the title [WIP] Mark long-failing packages broken for 18.09 (2) Mark long-failing packages broken for 18.09 (2) Sep 25, 2018
@xeji xeji removed the 2.status: work-in-progress This PR isn't done label Sep 25, 2018
@xeji
Copy link
Contributor Author

xeji commented Sep 25, 2018

Will merge this now as the our release date comes closer. Packages can be un-broken any time later...

@xeji xeji merged commit 62501ed into NixOS:master Sep 25, 2018
@xeji
Copy link
Contributor Author

xeji commented Sep 25, 2018

backported in 294060d..69514d7

@xeji xeji deleted the p/broken-1809 branch September 25, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xeji @7c6f434c @hrdinka @kini @Fuuzetsu @GrahamcOfBorg