Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop nix 2.18 #359215

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Drop nix 2.18 #359215

merged 3 commits into from
Dec 2, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 26, 2024 •
edited
Loading

Things done

Depends on #354148

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 marked this pull request as ready for review November 27, 2024 21:04
@Mic92 Mic92 requested review from liclac and a team November 27, 2024 21:13
@infinisil
Copy link
Member

infinisil commented Nov 28, 2024 •
edited
Loading

Why no throw alias?

@ofborg ofborg bot requested a review from 2xsaiko November 28, 2024 14:47
@Mic92
Copy link
Member Author

Mic92 commented Nov 30, 2024

Why no throw alias?

Fixed.

@Mic92
Copy link
Member Author

Mic92 commented Dec 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359215

x86_64-linux

✅ 4 packages built:
  • haskellPackages.nix-serve-ng
  • haskellPackages.nix-serve-ng.doc
  • nix-serve-ng
  • nix-web

aarch64-linux

✅ 4 packages built:
  • haskellPackages.nix-serve-ng
  • haskellPackages.nix-serve-ng.doc
  • nix-serve-ng
  • nix-web

x86_64-darwin

✅ 4 packages built:
  • haskellPackages.nix-serve-ng
  • haskellPackages.nix-serve-ng.doc
  • nix-serve-ng
  • nix-web

aarch64-darwin

❌ 1 package failed to build:
  • nix-serve-ng
✅ 3 packages built:
  • haskellPackages.nix-serve-ng
  • haskellPackages.nix-serve-ng.doc
  • nix-web

@roberth
Copy link
Member

roberth commented Dec 2, 2024

aarch64-darwin

❌ 1 package failed to build:

  • nix-serve-ng

Known issue

@Mic92 Mic92 merged commit 2e00fd6 into NixOS:master Dec 2, 2024
37 of 38 checks passed
@Mic92 Mic92 deleted the drop-nix-2.18 branch December 2, 2024 13:46
@roberth roberth mentioned this pull request Dec 2, 2024
Merged
13 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-12-02-nix-team-meeting-minutes-199/56961/1

@mweinelt
Copy link
Member

mweinelt commented Dec 4, 2024 •
edited
Loading

Funny. We just reverted the tarball-mirror script to 2.18, since newer release broke the API to check for valid store paths.

NixOS/infra@e8ae7d8

https://matrix.to/#/!sUXcTulPzyhnqOiFPL:helsinki-systems.de/$hyLkcAg8VmWY-YD0d5_q-X3aV_BdL4Fczkdia_XPNXs?via=helsinki-systems.de&via=matrix.org&via=nixos.dev

@vcunat
Copy link
Member

vcunat commented Dec 4, 2024

Maybe some other version in between also works well. For me it was just easiest to keep the version that we had until now (because it's 24.05 default).

@Mic92
Copy link
Member Author

Mic92 commented Dec 4, 2024 •
edited
Loading

@vcunat This function still exist but you need instantiate a store: https://github.com/NixOS/nix/blob/ff00eebb16fc4c0fd4cebf0cbfc63c471e3c4abd/src/perl/t/init.t#L9

There is no other nix version that is lower than 2.24 to migrate to. The proper fix is to upgrade it to the new API.

@vcunat
Copy link
Member

vcunat commented Dec 4, 2024

I do have code for that already. But we ran into other regressions instead:
NixOS/nix#11996
NixOS/nix#11997

@Mic92
Copy link
Member Author

Mic92 commented Dec 4, 2024

@vcunat ok. Here was my attempt: #361700

Aleksanaa added a commit that referenced this pull request Dec 8, 2024
@Aleksanaa
[Backport 24.11] Updates from #359215 (#361108)
5e7591e
@9999years
Copy link
Contributor

There is no other nix version that is lower than 2.24 to migrate to. The proper fix is to upgrade it to the new API.

This would be a lot more reasonable if Nix versions above 2.18 weren't full of bugs and regressions. See: NixOS/nix#11756 (comment)

This was referenced Dec 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2xsaiko 2xsaiko 2xsaiko left review comments

@roberth roberth roberth approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

@maralorn maralorn Awaiting requested review from maralorn

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@tomberek tomberek Awaiting requested review from tomberek

@liclac liclac Awaiting requested review from liclac

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Mic92 @infinisil @roberth @nixos-discourse @mweinelt @vcunat @9999years @2xsaiko