Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltex-ls-plus: init at 18.2.0 #357814

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

FirelightFlagboy
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy commented Nov 21, 2024

This adds the ltex-ls-plus package, which is a language server for LanguageTool.
It is a fork of the ltex-ls package with additional features & bugfixes.

It seems like the original ltex-ls is no longer maintained. I've decided to create a new package instead of changing the previous package with updated link.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 21, 2024
@FirelightFlagboy
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357814


x86_64-linux

✅ 1 package built:
  • ltex-ls-plus

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 22, 2024
Copy link
Member

@pinpox pinpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version to 18.3.0

@austinbutler
Copy link
Member

@pinpox
Copy link
Member

pinpox commented Dec 9, 2024

@vinnymeller would you be interested in being added as maintainer to this package too? Since you maintained the original ltex-ls package it might make sense to add you here.

FYI there's also these other open PRs for ltex-lsp-plus:

1. [lltex-ls-plus: init at 17.0.1; vscode-extensions.ltex-plus.vscode-ltex-plus: init at 14.0.2 #342724](https://github.com/NixOS/nixpkgs/pull/342724)

2. [ltex-ls-plus: init at 18.3.0 #363410](https://github.com/NixOS/nixpkgs/pull/363410)

I didn't see this PR and opened #363410. Closing as duplicate.

@pinpox
Copy link
Member

pinpox commented Dec 9, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357814


x86_64-linux

✅ 1 package built:
  • ltex-ls-plus

Co-authored-by: Pablo Ovelleiro Corral <[email protected]>
@Lassulus Lassulus merged commit 878ced9 into NixOS:master Dec 9, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants