lltex-ls-plus: init at 17.0.1; vscode-extensions.ltex-plus.vscode-ltex-plus: init at 14.0.2

[PhilippWoelfel]

Description of changes

This adds ltex-ls-plus and vscode-extensions.ltex-plus.vscode-ltex-plus, see https://ltex-plus.github.io/ltex-plus/ and https://github.com/ltex-plus/vscode-ltex-plus
It is a fork of ltex-ls (see https://github.com/valentjn/vscode-ltex) which seems to be unmaintained.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nyabinary]

Shouldn't this also add the vscode extension as well?

[PhilippWoelfel]

Shouldn't this also add the vscode extension as well?

I was thinking that the extension (vscode-ltex-plus) could be a separate pull request, if anyone is interested. Personally, I am using github:nix-community/nix-vscode-extensions to get the extension, and then configure it so that it uses the binary from this package (by setting the vscode option ltex.ltex-ls.path and also ltex.java.path).

Note that if we want to package the extension vscode-ltex-plus, we'd probably want to use the "offline" source, which already contains the binary from this package. Otherwise, the extension will just try to download the binary into the store path, which is doomed to fail. So these two packages don't really go together.

[nyabinary]

Shouldn't this also add the vscode extension as well?

I was thinking that the extension (vscode-ltex-plus) could be a separate pull request, if anyone is interested. Personally, I am using github:nix-community/nix-vscode-extensions to get the extension, and then configure it so that it uses the binary from this package (by setting the vscode option ltex.ltex-ls.path and also ltex.java.path).

Note that if we want to package the extension vscode-ltex-plus, we'd probably want to use the "offline" source, which already contains the binary from this package. Otherwise, the extension will just try to download the binary into the store path, which is doomed to fail. So these two packages don't really go together.

It could be the same PR, but has to be a different commit :3

[PhilippWoelfel]

It could be the same PR, but has to be a different commit :3

I added the extension. Not sure what the naming convention for the pull request is, though...?

[nyabinary]

It could be the same PR, but has to be a different commit :3

I added the extension. Not sure what the naming convention for the pull request is, though...?

ltex-ls-plus: init at 17.0.1; vscode-extensions.ltex-plus.vscode-ltex-plus: init at 14.0.2

should be oki

[FliegendeWurst]

Please squash your commits into two (one for each package). Then it is good to go.

[austinbutler]

FYI there's also two other open PRs for ltex-ls-plus:

1. ltex-ls-plus: init at 18.2.0 #357814
2. ltex-ls-plus: init at 18.3.0 #363410

Plus one already merged for the VS Code extension: #362085

[pinpox]

#357814 has been merged, adding the package, so this should be removed. Feel free to add yourself as maintainer though.