Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] lib.strings: add trim #354227

Merged
merged 1 commit into from
Dec 1, 2024
Merged

[Backport release-24.05] lib.strings: add trim #354227

merged 1 commit into from
Dec 1, 2024
+129 −1

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2024

Bot-based backport to release-24.05, triggered by a label in #315411.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@MattSturgeon @github-actions
lib.strings: add trim and trimWith
2416623 
`strings.trim` returns a copy of the string with all leading and trailing
whitespace removed.

`strings.trimWith` does the same thing, but calling code can decide
whether to trim the start and/or end of the string.

(cherry picked from commit aad87c2)
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Merged
13 tasks
@MattSturgeon
Copy link
Contributor

MattSturgeon commented Nov 7, 2024 •
edited
Loading

Should this backport should also include #330034 (and maybe the relevant parts of #323843)? Although this isn't vital since those PRs are documentation changes only.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 7, 2024
FliegendeWurst
FliegendeWurst approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see a reason to backport an unused function, but it doesn't hurt I guess.

(I do not expect the few backports still coming to use this)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 25, 2024
@wolfgangwalther wolfgangwalther merged commit 8d2e9b6 into release-24.05 Dec 1, 2024
17 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-315411-to-release-24.05 branch December 1, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattSturgeon @FliegendeWurst @wolfgangwalther @wegank