Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.trimWith: Minor doc improvements #330034

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

infinisil
Copy link
Member

Description of changes

Follow-up to #315411. Just something minor I spotted. I think it's best to make follow-up PRs instead of bikeshedding :)

Ping @MattSturgeon


Add a 👍 reaction to pull requests you find important.

@infinisil infinisil requested a review from MattSturgeon July 25, 2024 23:18
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jul 25, 2024
@infinisil infinisil mentioned this pull request Jul 25, 2024
13 tasks
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I would've been happy to do this on the original PR, but thanks for handling these improvements.

@infinisil
Copy link
Member Author

Haha thanks, I sometimes feel bad if there's too many review cycles with just super minor comments 😆

@infinisil infinisil merged commit 9ba898d into NixOS:master Jul 25, 2024
9 of 10 checks passed
@infinisil infinisil deleted the trim-minor-improvements branch July 25, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants