Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cli-extensions: update package set #353094

Merged
merged 40 commits into from
Nov 8, 2024

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Nov 2, 2024

First extension update after #352668

Also some minor fixes to the extensions-tool, changing the commit order, adding a workaround for a commit authorship bug in gitpython, and adding the extensions-tool to azure-cli tests to ensure it builds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

These are most likely to require human intervention, having them last simplifies rebase.

Signed-off-by: Paul Meyer <[email protected]>
I accidentally removed it during an extensions update. It wasn't actually removed upstream, just has external requirements now.

Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen force-pushed the azure-cli-extensions/update-set branch from de7ae95 to 2fb100c Compare November 2, 2024 16:17
@katexochen katexochen requested a review from ulrikstrid November 2, 2024 16:25
@katexochen katexochen changed the title Azure cli extensions/update set azure-cli-extensions: update package set Nov 2, 2024
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 3, 2024
@katexochen katexochen requested a review from msanft November 7, 2024 10:47
@katexochen katexochen added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 7, 2024
@katexochen katexochen merged commit 6a0ff47 into NixOS:master Nov 8, 2024
50 checks passed
@katexochen katexochen deleted the azure-cli-extensions/update-set branch November 8, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants