azure-cli: rewrite extensions-tool in python #352668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matej Urbas <[email protected]> Co-authored-by: Sebastian Kowalak <[email protected]> Signed-off-by: Paul Meyer <[email protected]>
This was done with the following cursed sed expression: tail -n +3 extensions-generated.nix | sed -e 's/ = mkAzExtension rec / : /g' -e 's/=/:/g' -e 's/;/,/g' -e 's/\([a-zA-Z_][a-zA-Z_0-9-]*\) :/"\1":/g' -e '/^[[:space:]]*"description"/s/.$//' > extensions-generated.json and some cleanup afterwards. Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
…to sri Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
|
I have not looked at the python script yet, the other diff looks good however. |
urbas
approved these changes
Oct 31, 2024
wegank
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 0
skowalak
approved these changes
Nov 1, 2024
wegank
added
12.approvals: 2
ulrikstrid
approved these changes
Nov 2, 2024
|
This seems to be good to go, thank you to everyone involved ❤️ |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342214
Migrates the package set to SRI hash (#325892)
Really big thanks to @skowalak and @urbas who hacked together with me on this at NixCon.
I transformed the existing set manually to ensure this is a zero-rebuild PR. You can run the update locally to check its functionality:
The updates that are currently found will then be made in a separate PR.
As follow up, we can also implement update of single, manually-packaged extensions in the python script.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.