python312Packages.gradio: 4.44.1 -> 5.1.0 #349625

pbsds · 2024-10-18T20:28:14Z

Things done

Add a 👍 reaction to pull requests you find important.

pbsbot · 2024-10-18T21:20:44Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

`x86_64-linux`

❌ 2 packages failed to build:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

pbsds · 2024-10-22T17:32:44Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

`aarch64-linux`

⏩ 2 packages marked as broken and skipped:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`x86_64-darwin`

⏩ 2 packages marked as broken and skipped:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`aarch64-darwin`

⏩ 2 packages marked as broken and skipped:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

GaetanLepage

LGTM !
If you have the patience, maybe go with:

getting rid of with lib; in the meta attrs
nativeBuildInputs -> build-system in gradio

GaetanLepage · 2024-10-22T20:31:26Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

`x86_64-linux`

❌ 2 packages failed to build:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`aarch64-linux`

⏩ 2 packages marked as broken and skipped:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`x86_64-darwin`

⏩ 2 packages marked as broken and skipped:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`aarch64-darwin`

⏩ 2 packages marked as broken and skipped:

python311Packages.private-gpt
python311Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

pkgs/development/python-modules/gradio-pdf/default.nix

pkgs/development/python-modules/gradio/default.nix

GaetanLepage

LGTM !

GaetanLepage · 2024-10-26T18:15:07Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

`x86_64-linux`

❌ 6 packages failed to build:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`aarch64-linux`

⏩ 6 packages marked as broken and skipped:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`x86_64-darwin`

⏩ 6 packages marked as broken and skipped:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`aarch64-darwin`

⏩ 6 packages marked as broken and skipped:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

GaetanLepage · 2024-10-26T18:17:20Z

Failures are unrelated. Feel free to merge :)

pbsds · 2024-10-29T17:56:33Z

will have to wait for stable branch-off

fabaff · 2024-10-31T21:31:11Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

`x86_64-linux`

❌ 10 packages failed to build:

private-gpt
private-gpt.dist
python311Packages.gradio
python311Packages.gradio.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.gradio
python312Packages.gradio.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 8 packages built:

python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist

       > Checking runtime dependencies for gradio-5.1.0-py3-none-any.whl
       >   - aiofiles<24.0,>=22.0 not satisfied by version 24.1.0
       >   - markupsafe~=2.0 not satisfied by version 3.0.1

Unfortunately an update to 5.4.0 will not help much. Looks like we need to add pythonRelaxDeps.

Diff: https://github.com/gradio-app/gradio/compare/refs/tags/[email protected]

pbsds · 2024-11-01T15:20:23Z

fixed it here, but since the bump is a breaking change, i also made #352893

GaetanLepage · 2024-11-02T07:58:19Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

`x86_64-linux`

❌ 6 packages failed to build:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`aarch64-linux`

⏩ 6 packages marked as broken and skipped:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`x86_64-darwin`

⏩ 6 packages marked as broken and skipped:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

`aarch64-darwin`

⏩ 6 packages marked as broken and skipped:

private-gpt
private-gpt.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python312Packages.private-gpt
python312Packages.private-gpt.dist

✅ 12 packages built:

python311Packages.gradio
python311Packages.gradio-client
python311Packages.gradio-client.dist
python311Packages.gradio-pdf
python311Packages.gradio-pdf.dist
python311Packages.gradio.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist

GaetanLepage

private-gpt failures are surely unrelated.

github-actions bot added the 6.topic: python label Oct 18, 2024

pbsds marked this pull request as ready for review October 18, 2024 20:28

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 19, 2024

pbsds requested a review from GaetanLepage October 22, 2024 17:33

GaetanLepage approved these changes Oct 22, 2024

View reviewed changes

wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 22, 2024

pbsds force-pushed the bump-gradio-1729275338 branch from 39ae9c1 to c521a1e Compare October 26, 2024 06:44

GaetanLepage requested changes Oct 26, 2024

View reviewed changes

pkgs/development/python-modules/gradio-pdf/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/gradio-pdf/default.nix Show resolved Hide resolved

pkgs/development/python-modules/gradio/default.nix Outdated Show resolved Hide resolved

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024

pbsds force-pushed the bump-gradio-1729275338 branch 2 times, most recently from b84126f to 9f38be9 Compare October 26, 2024 16:18

GaetanLepage approved these changes Oct 26, 2024

View reviewed changes

fabaff mentioned this pull request Oct 31, 2024

python312Packages.llama-index-core: 0.11.16 -> 0.11.20 #352714

Merged

13 tasks

pbsds added 3 commits November 1, 2024 16:13

python312Packages.gradio: 4.44.1 -> 5.1.0

d131ae7

python312Packages.gradio-pdf: 0.0.15 -> 0.0.17

bac1070

python312Packages.gradio-client: 1.3.0 -> 1.4.0

5f3c27a

Diff: https://github.com/gradio-app/gradio/compare/refs/tags/[email protected]

pbsds mentioned this pull request Nov 1, 2024

python312Packages.gradio: relax aiofiles and markupfiles #352893

Merged

13 tasks

pbsds force-pushed the bump-gradio-1729275338 branch from 9f38be9 to 5f3c27a Compare November 1, 2024 15:19

GaetanLepage approved these changes Nov 2, 2024

View reviewed changes

wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024

GaetanLepage merged commit cfc2393 into NixOS:master Nov 2, 2024
28 of 29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python312Packages.gradio: 4.44.1 -> 5.1.0 #349625

python312Packages.gradio: 4.44.1 -> 5.1.0 #349625

pbsds commented Oct 18, 2024 •

edited

Loading

pbsbot commented Oct 18, 2024

pbsds commented Oct 22, 2024

GaetanLepage left a comment

GaetanLepage commented Oct 22, 2024

GaetanLepage left a comment

GaetanLepage commented Oct 26, 2024

GaetanLepage commented Oct 26, 2024

pbsds commented Oct 29, 2024

fabaff commented Oct 31, 2024 •

edited

Loading

pbsds commented Nov 1, 2024

GaetanLepage commented Nov 2, 2024

GaetanLepage left a comment

python312Packages.gradio: 4.44.1 -> 5.1.0 #349625

python312Packages.gradio: 4.44.1 -> 5.1.0 #349625

Conversation

pbsds commented Oct 18, 2024 • edited Loading

Things done

pbsbot commented Oct 18, 2024

nixpkgs-review result

x86_64-linux

pbsds commented Oct 22, 2024

nixpkgs-review result

aarch64-linux

x86_64-darwin

aarch64-darwin

GaetanLepage left a comment

Choose a reason for hiding this comment

GaetanLepage commented Oct 22, 2024

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

GaetanLepage left a comment

Choose a reason for hiding this comment

GaetanLepage commented Oct 26, 2024

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

GaetanLepage commented Oct 26, 2024

pbsds commented Oct 29, 2024

fabaff commented Oct 31, 2024 • edited Loading

nixpkgs-review result

x86_64-linux

pbsds commented Nov 1, 2024

GaetanLepage commented Nov 2, 2024

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

GaetanLepage left a comment

Choose a reason for hiding this comment

pbsds commented Oct 18, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

fabaff commented Oct 31, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`